Redo fix for FSMonitor #3287
Merged
Redo fix for FSMonitor #3287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emon via IPC Signed-off-by: Jeff Hostetler <[email protected]>
derrickstolee
approved these changes
Jun 21, 2021
jeffhostetler
approved these changes
Jun 21, 2021
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 26, 2021
Redo fix for FSMonitor
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 29, 2021
Redo fix for FSMonitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3263, I fixed the issue where
fsmonitor_ipc__send_query()was called withNULLaslast_token, by simply not calling that function.That works, but it is undesirable: it means that we do not even query the FSMonitor, and therefore do not get a token back, but instead store a dummy token and do a full scan. The next time we hit this code path, we do query the FSMonitor, but with a dummy token, and therefore cause another full scan.
By instead calling that function with a dummy token right away we do get back a valid token, and the second time we hit that code path we can reap the full benefit of the FSMonitor.
This is a companion of microsoft#385.