Allow Ctrl+C to interrupt clone via SSH again #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
1 task
Currently, ENABLE_PROCESSED_INPUT is set in set_input_mode() if master_thread_suspended is true. This enables Ctrl-C handling when cons_master_thread is suspended, since Ctrl-C is normally handled by cons_master_thread. However, when disable_master_thread is true, ENABLE_PROCESSED_INPUT is not set, even though this also disables Ctrl-C handling in cons_master_thread. Due to this bug, the command C:\cygwin64\bin\sleep 10 < NUL in the Command Prompt cannot be terminated with Ctrl-C. This patch addresses the issue by setting ENABLE_PROCESSED_INPUT when either disable_master_thread or master_thread_suspended is true. This bug also affects cases where non-Cygwin Git (Git for Windows) launches Cygwin SSH. In such cases, SSH also cannot be terminated with Ctrl-C. Addresses: git-for-windows/git#5682 (comment) Fixes: 746c811 ("Cygwin: console: Allow pasting very long text input.") Reported-by: Johannes Schindelin <[email protected]> Signed-off-by: Takashi Yano <[email protected]> (cherry picked from commit 476135a24506dd624eb46b50fd634fcd740008ba) Cherry-picked-from: 61cc419 (Cygwin: console: Set ENABLE_PROCESSED_INPUT when disable_master_thread, 2025-07-01)) Signed-off-by: Johannes Schindelin <[email protected]>
|
/open pr The workflow run was started |
This comment was marked as outdated.
This comment was marked as outdated.
github-actions bot
pushed a commit
to git-for-windows/build-extra
that referenced
this pull request
Jul 1, 2025
In Git for Windows v2.50.0, operations using the POSIX emulation layer (cloning via SSH, generating the Bash prompt) cannot be interrupted by Ctrl+C, which [has been fixed](git-for-windows/msys2-runtime#104). Signed-off-by: gitforwindowshelper[bot] <[email protected]>
This was referenced Jul 1, 2025
MarkEWaite
added a commit
to MarkEWaite/docker-lfs
that referenced
this pull request
Jul 2, 2025
* Cloning: large repositories via SSH frequently hung with Git for Windows v2.50.0 git-for-windows/git#5688 fixed in git-for-windows/msys2-runtime#103 * In: Git for Windows v2.50.0, operations using the POSIX emulation layer (cloning via SSH, generating the Bash prompt) cannot be interrupted by Ctrl+C, fixed in git-for-windows/msys2-runtime#104 * Git: for Windows v2.50.0 is unable to initialize Git repositories on Windows Server 2016 git-for-windows/git#5695), fixed in git-for-windows/git#5700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that a lengthy clone via SSH cannot be interrupted via Ctrl+C anymore.
This can be reproduced by cloning a large-ish repository via SSH, but even
C:\cygwin64\bin\sleep 10 < NULin a Windows Terminal will reproduce it.I had reported this to the Cygwin developers and they fixed it, and in this PR here I cherry-pick the fix (cygwin/cygwin@61cc419b2b).