Adjust CWD magic to accommodate for the latest Windows previews #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reportedly Windows 11 build 25*** from Insider changed the current working directory logic a bit, and Cygwin's "magic" (or: "technologically sufficiently advanced") code needs to be adjusted accordingly. This fixes git-for-windows/git#4429 Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
adjust-cwd-magic-to-newest-windows
branch
from
61d302a to
611c81d
Compare
1 task
Member
|
Confirmed that artifacts from the PR build fix git-for-windows/git#4429. Merging... |
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
May 18, 2023
… previews This is the companion commit to git-for-windows/msys2-runtime#52 Signed-off-by: Johannes Schindelin <[email protected]>
Member
Author
|
I fear at some stage we may need to backport this to msys2-runtime-3.3... |
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
May 18, 2023
…dows previews This is the i686-specific companion commit to git-for-windows/msys2-runtime#52 Signed-off-by: Johannes Schindelin <[email protected]>
Member
Author
|
Contributor
|
should this be upstreamed to cygwin, or do they prefer to wait for the final Windows release? |
Member
Author
This should be upstreamed to Cygwin, I'm just a bit underwater, otherwise I'd already have done it. |
Member
Author
|
Member
Author
|
@jeremyd2019 it was accepted in upstream: cygwin/cygwin@4840a56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reportedly Windows 11 build 25*** from Insider changed the current working directory logic a bit, and Cygwin's "magic" (or: "technologically sufficiently advanced") code needs to be adjusted accordingly.
This fixes git-for-windows/git#4429