Activity page: commit day labels before yesterday seem to be one day off

[nimmerland]

gitblit 1.8.0 GO, on win7, java8, firefox 54.0.1,
language setting DE (EN also tested and used for screenshots)

Hi,

on the activity page that shows the latest number of commits are labels for grouping the commits by day (like today, yesterday). For today and yesterday those labels are correct.

But right after yesterday shows a label '3 days ago' which has commits from 2 days ago. The tooltip for the commit time label however does correctly show '2 days ago':

On the my dashboard page the same commits are also shown correctly as '2 days ago'.

Thanks for everyones efforts on gitblit.

[AmishP]

I have seen the same on my install. I know this is a year old but I can look into fixing it. But I noticed there has not been any updates in the last 2 years.

[flaix]

As usual with time and date related problems, this is a rather tricky one.
For one, it could be simply time zones being disregarded in calculations, or it could be wrong rounding in the daysAgo method.
Then, the TimeUtil methods are used in various places where a time difference is displayed in the UI. Without checking where what is needed, fixing anything could break other places.
In any case, any fix can only be a temporary band aid. I think the whole time handling needs to be rewritten once Gitblit switches to Java 8.