Skip to content

Add ability to run plugin manager as modal window #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Oct 30, 2020
Merged

Add ability to run plugin manager as modal window #47

merged 1 commit into from Oct 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2020

fixes #13

RussKie
RussKie reviewed Oct 23, 2020
View reviewed changes
@ghost ghost requested a review from RussKie October 23, 2020 12:55
@RussKie
Copy link
Member

RussKie commented Oct 23, 2020

Can you please provide more information what this change does. It is not clear what the original issue is, and what we are gaining with the change.

@RussKie RussKie requested review from maraf and mast-eu October 23, 2020 12:59
@ghost
Copy link
Author

ghost commented Oct 23, 2020

After we run plugin manager it works like modal window and prevent run another PM window.

@ghost

This comment has been minimized.

Sign in to view
@ghost

This comment has been minimized.

Sign in to view
@maraf
Copy link
Member

maraf commented Oct 23, 2020

I think this doesn't prevent launching plugin manager from other instance of Git Extensions.
Maybe we can use WindowsFormsApplicationBase to allow only a single instance of plugin manager.

@ghost
Copy link
Author

ghost commented Oct 23, 2020

CloseAllOtherInstances?

image

@maraf
Copy link
Member

maraf commented Oct 23, 2020

The snippet you picked closes all running instances of Git Extensions. The issue referes to instances of Plugin Manager.

maraf
maraf approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Thank you.

mast-eu
mast-eu approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@mast-eu mast-eu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this PR is ready to be merged.

@RussKie : Do you still have something to add?

@RussKie
Copy link
Member

RussKie commented Oct 29, 2020

Interop definitions can be improved, but it isn't critical.
LGTM

@mast-eu mast-eu merged commit 52c2db9 into gitextensions:master Oct 30, 2020
@mast-eu
Copy link
Member

mast-eu commented Oct 30, 2020

Thank you.

@mast-eu mast-eu added this to the 1.2.0 milestone Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie Awaiting requested review from RussKie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Plugin manager as modal window over GitExtensions
3 participants
@RussKie @maraf @mast-eu