Skip to content

Conversation

maraf
Copy link
Member

@maraf maraf commented Dec 10, 2020

#53 - Show package details on Installed and Updates tab.

I'm not happy with the level on UI code duplication in XAMLs, but can't figure out how to do better. If you accept it, I'm going to leave at as is and return to it in (near) future.

Screenshots

2020-12-10_105147

2020-12-10_105311

@maraf maraf self-assigned this Dec 10, 2020
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is embarrassing but I don't really know how to use WPF... The screenshots look great though ;)

@mast-eu
Copy link
Member

mast-eu commented Dec 10, 2020

I really like the idea to share the same look&feel on all three tabs.

@maraf
Copy link
Member Author

maraf commented Dec 11, 2020

It is embarrassing but I don't really know how to use WPF...

But you are a WinForms guru, you don't need WPF 😎

Anyway, thank you both for the feedback.

@maraf
Copy link
Member Author

maraf commented Dec 20, 2020

I'm not happy with the level on UI code duplication in XAMLs, but can't figure out how to do better. If you accept it, I'm going to leave at as is and return to it in (near) future.

Cleanup up the history. Ready to review.

@maraf maraf marked this pull request as ready for review December 20, 2020 19:45
@maraf maraf requested review from mast-eu and RussKie December 21, 2020 09:22
@RussKie
Copy link
Member

RussKie commented Dec 21, 2020

:shipit:

Copy link
Member

@mast-eu mast-eu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mast-eu mast-eu added this to the 1.2.0 milestone Dec 21, 2020
@maraf maraf merged commit 2ff770e into gitextensions:master Dec 22, 2020
@maraf maraf deleted the PackageDetails branch December 22, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants