Skip to content

Migration to .NET 5 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

Migration to .NET 5 #58

merged 1 commit into from
Nov 3, 2021

Conversation

maraf
Copy link
Member

@maraf maraf commented Nov 1, 2021

  • Replaced costura with .NET single file publish.
  • Fixed package source ordering in Nuget.PackageManagement-v5.11.0.
  • Updated release script.

Fixes #57.

@maraf
Migration to .NET 5
ab15af8 
- Replaced costura with .NET single file publish.
- Fixed package source ordering in Nuget.PackageManagement-v5.11.0.
@maraf maraf requested review from RussKie and mast-eu November 1, 2021 10:10
RussKie
RussKie approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible :shipit:

@maraf maraf added this to the 1.2.0 milestone Nov 3, 2021
@maraf maraf merged commit 1132651 into gitextensions:master Nov 3, 2021
@maraf maraf deleted the Net5 branch November 3, 2021 14:52
@RussKie
Copy link
Member

RussKie commented Nov 6, 2021

I'm testing the .NET 5.0 release, and the Plugin Manager is failing to start with the following error:

Description: A .NET application failed.
Application: PackageManager.UI.exe
Path: D:\Development\gitextensions\artifacts\Release\publish\GitExtensions-Portable-33.33.33.0-0af3f84d3\UserPlugins\GitExtensions.PluginManager\PackageManager\PackageManager.UI.exe
Message: The application to execute does not exist: 'D:\Development\gitextensions\artifacts\Release\publish\GitExtensions-Portable-33.33.33.0-0af3f84d3\UserPlugins\GitExtensions.PluginManager\PackageManager\PackageManager.UI.dll'.

It looks like it is looking for PackageManager.UI.dll, and there's only a PackageManager.UI.exe....

@RussKie
Copy link
Member

RussKie commented Nov 6, 2021 •
edited
Loading

You can grab build artifacts here: https://ci.appveyor.com/project/gitextensions/gitextensions/builds/41427744/artifacts, or use the branch if you want to build it locally: https://github.com/gitextensions/gitextensions/tree/msi

@maraf
Copy link
Member Author

maraf commented Nov 8, 2021 •
edited
Loading

@RussKie Are you using MSI or portable? Because with portable from the link about it seems the PM is working (it shows an error with reading settings, but the PM starts and works).

I struggling to run the installer on sandbox machine. I have there .NET 5.0.12 runtime, but it still says that I don't and clicking yes does nothing. Anyway, the portable version runs there...

image

@maraf
Copy link
Member Author

maraf commented Nov 8, 2021

💡 Also, the installer and portable still contains an previous PM version (1.1.0.109).
So, I think we need to first release the PM v2.0 and than we can test the GE installer. Correct?

@gerhardol
Copy link
Member

gitextensions/gitextensions#9704 to build installer with msbuild explicitly
(but I do not get it built myself)

@RussKie
Copy link
Member

RussKie commented Nov 8, 2021 via email

@maraf
Copy link
Member Author

maraf commented Nov 11, 2021 •
edited
Loading

I probably found the problem. The build on AppVeyor doesn't work as locally.

image

Size of these artifacts should be about 4MB.

The problem is with single file publish of PackageManager UI.
It seems it ignores the publish profile.

When I run the build script (Prepare-Release.ps1) locally, it produces correct artifacts.

image

@RussKie Any ideas?

maraf added a commit to maraf/gitextensions.pluginmanager that referenced this pull request Nov 11, 2021
@maraf
Fix unit tests after gitextensions#58.
8045f4c 
- Moving package down in sources collection wasn't working.
- Remove --no-build from Run-Tests.ps1, because we don't build whole solution in previous steps.
@maraf maraf mentioned this pull request Nov 11, 2021
Merged
maraf added a commit to maraf/gitextensions.pluginmanager that referenced this pull request Nov 12, 2021
@maraf
Fix publish on .NET 5.
7c34f4d 
- Replace publish profile with direct arguments in Prepare-Release.ps1.
- Generate binlogs during publish.

This is follow-up to gitextensions#58.
@maraf maraf mentioned this pull request Nov 12, 2021
Merged
maraf added a commit that referenced this pull request Nov 12, 2021
@maraf
Merge pull request #59 from maraf/Net5FixTests
291141c 
Fix unit tests after #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

@mast-eu mast-eu Awaiting requested review from mast-eu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Support .NET
3 participants
@maraf @RussKie @gerhardol