Skip to content

Target .NET 8 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2024
Merged

Target .NET 8 #73

merged 6 commits into from
Jul 15, 2024

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Nov 26, 2023

@RussKie RussKie requested a review from maraf November 26, 2023 07:21
@RussKie

This comment was marked as resolved.

Sign in to view
@RussKie RussKie mentioned this pull request Nov 26, 2023
Merged
@RussKie
Copy link
Member Author

RussKie commented Nov 27, 2023 via email

@maraf
Copy link
Member

maraf commented Nov 27, 2023

Tested locally, the GitExtensions-v4.3.0.17614 won't offer the plugin in Plugin menu, although debugger says it has found and loaded the assembly. Does it work for you?

Starting the UI app separately all operations work correctly

@RussKie RussKie mentioned this pull request Dec 1, 2023
Merged
@RussKie
Copy link
Member Author

RussKie commented Dec 3, 2023

Tested locally, the GitExtensions-v4.3.0.17614 won't offer the plugin in Plugin menu

Could you please describe the local testing procedure?

@maraf
Copy link
Member

maraf commented Dec 4, 2023 •
edited
Loading

Could you please describe the local testing procedure?

  1. Publish PackageManager.UI
  2. Run GitExtensions.PluginManager

The first step should produce a ..\PackageManager.UI\bin\$(Configuration)\$(TargetFramework)\publish\PackageManager.UI.exe. The second one should download latest Git Extensions from AppVeyor, copy the plugin into it and run the GitExtensions.exe

@RussKie
Copy link
Member Author

RussKie commented Jun 23, 2024

@maraf do you think you could give me a hand in getting this over the finish line?

@maraf
Copy link
Member

maraf commented Jun 23, 2024

I'm happy to, but I'm AFK till 7/7. If you're willing to wait, I'm happy to jump on it.

@RussKie
Copy link
Member Author

RussKie commented Jul 13, 2024

A gentle nudge

@maraf
Copy link
Member

maraf commented Jul 13, 2024

Are we trying to target latest GE on AppVeyor (GitExtensions-v4.3.0.17863) with this?

@maraf

This comment was marked as resolved.

Sign in to view
@maraf
Copy link
Member

maraf commented Jul 13, 2024

It should be ready to go! In review you can omit the last commit 61ebd48, it something VS suggested to me

@RussKie
Copy link
Member Author

RussKie commented Jul 14, 2024

It should be ready to go! In review you can omit the last commit 61ebd48, it something VS suggested to me

Thank you.
Do you think we could exclude 61ebd48 from this PR and push it separately?

@RussKie
Copy link
Member Author

RussKie commented Jul 14, 2024 •
edited
Loading

And, if you're think it's ready to go, please approve, so I can I have it merged.

@RussKie RussKie merged commit ff53a97 into master Jul 15, 2024
@RussKie
Copy link
Member Author

RussKie commented Jul 15, 2024

Thank you!

@RussKie RussKie deleted the net8 branch July 15, 2024 12:51
@RussKie RussKie mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraf maraf maraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RussKie @maraf