Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 68edb71

Browse files
committed
Ported changes from #1543.
Fix a few theming issues.
1 parent 9f70ca9 commit 68edb71

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

src/GitHub.VisualStudio.UI/Styles/ThemeBlue.xaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,6 @@
6464

6565
<SolidColorBrush x:Key="GitHubPeekViewBackground" Color="#F5F5F5" />
6666
<SolidColorBrush x:Key="GitHubPendingReviewBackground" Color="#FFF8C7" />
67-
<SolidColorBrush x:Key="GitHubMultilineListItemActiveBrush" Color="#FFCCCEDB"/>
67+
<SolidColorBrush x:Key="GitHubMultilineListItemActiveBrush" Color="#FFCCCEDB" />
68+
<SolidColorBrush x:Key="GitHubFileExpanderHeaderBackgroundBrush" Color="#FFD6DBE9" />
6869
</ResourceDictionary>

src/GitHub.VisualStudio.UI/Styles/ThemeDark.xaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,5 @@
6565
<SolidColorBrush x:Key="GitHubPeekViewBackground" Color="#252526" />
6666
<SolidColorBrush x:Key="GitHubPendingReviewBackground" Color="#26384D" />
6767
<SolidColorBrush x:Key="GitHubMultilineListItemActiveBrush" Color="#FF3F3F46"/>
68+
<SolidColorBrush x:Key="GitHubFileExpanderHeaderBackgroundBrush" Color="#FF2D2D30" />
6869
</ResourceDictionary>

src/GitHub.VisualStudio.UI/Styles/ThemeLight.xaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,5 @@
6565
<SolidColorBrush x:Key="GitHubPeekViewBackground" Color="#F5F5F5" />
6666
<SolidColorBrush x:Key="GitHubPendingReviewBackground" Color="#FFF8C7" />
6767
<SolidColorBrush x:Key="GitHubMultilineListItemActiveBrush" Color="#FFCCCEDB"/>
68+
<SolidColorBrush x:Key="GitHubFileExpanderHeaderBackgroundBrush" Color="#FFEEEEF2" />
6869
</ResourceDictionary>

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestFileCommentsView.xaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@
4242
<Setter Property="Template">
4343
<Setter.Value>
4444
<ControlTemplate TargetType="{x:Type GroupItem}">
45-
<Expander Background="{DynamicResource {x:Static SystemColors.ControlBrushKey}}"
46-
Foreground="{DynamicResource {x:Static SystemColors.ControlTextBrushKey}}"
45+
<Expander Background="{DynamicResource GitHubFileExpanderHeaderBackgroundBrush}"
46+
Foreground="{DynamicResource VsBrush.WindowText}"
4747
IsExpanded="True"
4848
Padding="0 4 4 4">
4949
<Expander.Header>
@@ -53,6 +53,7 @@
5353
<ghfvs:OcticonImage DockPanel.Dock="Right" Icon="comment" Margin="2 0 2 -2"/>
5454
<ghfvs:TrimmedPathTextBlock Grid.Column="1"
5555
FontWeight="SemiBold"
56+
Foreground="{DynamicResource VsBrush.WindowText}"
5657
Text="{Binding Name}"
5758
ToolTip="{Binding Name}"/>
5859
</DockPanel>
@@ -61,7 +62,7 @@
6162
Grid.IsSharedSizeScope="True">
6263
<ItemsControl.ItemTemplate>
6364
<DataTemplate>
64-
<Border BorderBrush="{DynamicResource {x:Static SystemColors.ControlBrushKey}}"
65+
<Border BorderBrush="{DynamicResource GitHubFileExpanderHeaderBackgroundBrush}"
6566
BorderThickness="1 0 1 1">
6667
<ghfvs:GitHubActionLink Command="{Binding Open}"
6768
Content="{Binding Body, Converter={ghfvs:TrimNewlinesConverter}, Mode=OneWay}"

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestUserReviewsView.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
</TextBlock>
7070
</StackPanel>
7171
</Expander.Header>
72-
<StackPanel Margin="16 4 0 4"
72+
<StackPanel Margin="21 4 0 4"
7373
Visibility="{Binding HasDetails, Converter={ghfvs:BooleanToVisibilityConverter}}">
7474
<Expander Foreground="{DynamicResource GitHubVsToolWindowText}"
7575
IsExpanded="True"

0 commit comments

Comments
 (0)