Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@donokuda
Copy link
Contributor

There's still a handful of things to address still, but I wanted to get these in sooner than later.

I think one of the last things to fix here is making the dropdown triangle the same color as VsBrush.WindowKey. However, I want to use the same type of triangle seen in other places inside of Visual Studio:


Screenshots

screen shot 2018-03-19 at 11 21 51 am

screen shot 2018-03-19 at 11 21 36 am

screen shot 2018-03-19 at 11 21 07 am

@donokuda
Copy link
Contributor Author

Pushed some changes to the "Create a review" view:

  • Tighten up spacing between header + PR title
  • Added a bit more spacing before the summary text field
  • Fixed theming
  • Change "Review summary" label to "Your review summary" (to be closer to the title of the view)

Before

screen shot 2018-03-19 at 2 28 41 pm

screen shot 2018-03-19 at 2 28 24 pm

After

screen shot 2018-03-19 at 2 23 59 pm

screen shot 2018-03-19 at 2 23 44 pm

screen shot 2018-03-19 at 2 23 28 pm

@donokuda
Copy link
Contributor Author

ok, I'm going to take a step back from this pull request for real 😛

One thing I'm stuck on and could use some guidance is how to change the expander arrow/triangle to the default version that (I assume) we get from Visual Studio:

I believe the ones we use here are the triangle down octicons

screen shot 2018-03-19 at 5 00 15 pm

But I'd rather use the ones we see in the headers for each section (next to "Description," "Reviewers," etc)

screen shot 2018-03-19 at 4 59 14 pm

By using the default expander triangle, we'll fit better with the Visual Studio UI brand. Also hoping it's less code to maintain in the long run 🤞

Copy link
Contributor

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm currently porting this branch to #1491 so will port these changes as well, and modify the Expander style to match SectionControl there too 👍

@grokys grokys merged commit a46a2b7 into feature/pr-reviews Mar 20, 2018
@grokys grokys deleted the ui/dynamic-pr-review-colors branch March 20, 2018 14:25
grokys added a commit that referenced this pull request Mar 20, 2018
Fix a few theming issues.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants