-
Couldn't load subscription status.
- Fork 1.2k
Fix a few theming issues #1543
Fix a few theming issues #1543
Conversation
plus fix a few other spacing opportunities
When authoring a review
|
ok, I'm going to take a step back from this pull request for real 😛 One thing I'm stuck on and could use some guidance is how to change the expander arrow/triangle to the default version that (I assume) we get from Visual Studio: I believe the ones we use here are the triangle down octicons But I'd rather use the ones we see in the headers for each section (next to "Description," "Reviewers," etc) By using the default expander triangle, we'll fit better with the Visual Studio UI brand. Also hoping it's less code to maintain in the long run 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm currently porting this branch to #1491 so will port these changes as well, and modify the Expander style to match SectionControl there too 👍







There's still a handful of things to address still, but I wanted to get these in sooner than later.
I think one of the last things to fix here is making the dropdown triangle the same color as
VsBrush.WindowKey. However, I want to use the same type of triangle seen in other places inside of Visual Studio:Screenshots