Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Make PR details pane layout more consistent with GitHub #1452

@jcansdale

Description

@jcansdale

GitHub.com PR pages show information about a PR in a way that more information that the user is likely to want to see soonest is towards the top. For example:

  1. The title, number and branch of the PR
  2. Reviewers, review status and link to reviews
  3. The long description of the PR
  4. Comments and inline comments
  5. CI status and merge/update PR buttons
  6. Link to external open this in GitHub Desktop

GitHub for Visual Studio currently displays information in the following order:

  1. The title, number and branch of the PR
  2. The long description of the PR
  3. Reviewers, review status and link to reviews
  4. Link to external view conversation on GitHub
  5. Changed file tree / links to inline comments

Rational

I propose we change the order to be more consistent with GitHub.com and show information in the order the user is likely to want to consume it (or if familiar with from github.com).

  • The author of a PR and other reviewers will most likely want to see the status of a PR and who has reviewed it first, before drilling down into the long description and changed file tree.
  • The user might want to navigate to view conversation on GitHub once they're reviewed PR description, changed files and inline comments.
  • The view conversation on GitHub link can get lost in its current position when a PR has a long description and many changed files (particularly if the description has links at the bottom).

We could show the information in the following order:

  1. The title, number and branch of the PR
  2. Reviewers, review status and link to reviews
  3. The long description of the PR
  4. Changed file tree / links to inline comments
  5. Link to external view conversation on GitHub

What do you think?

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions