This repository was archived by the owner on Jun 21, 2023. It is now read-only.
-
Couldn't load subscription status.
- Fork 1.2k
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Make PR details pane layout more consistent with GitHub #1452
Copy link
Copy link
Open
Labels
Description
- GitHub Extension for Visual Studio version:
feature/pr-reviewsWIP: Spike of Pull Request Reviews feature. #1415
GitHub.com PR pages show information about a PR in a way that more information that the user is likely to want to see soonest is towards the top. For example:
- The title, number and branch of the PR
- Reviewers, review status and link to reviews
- The long description of the PR
- Comments and inline comments
- CI status and merge/update PR buttons
- Link to external
open this in GitHub Desktop
GitHub for Visual Studio currently displays information in the following order:
- The title, number and branch of the PR
- The long description of the PR
- Reviewers, review status and link to reviews
- Link to external
view conversation on GitHub - Changed file tree / links to inline comments
Rational
I propose we change the order to be more consistent with GitHub.com and show information in the order the user is likely to want to consume it (or if familiar with from github.com).
- The author of a PR and other reviewers will most likely want to see the status of a PR and who has reviewed it first, before drilling down into the long description and changed file tree.
- The user might want to navigate to
view conversation on GitHubonce they're reviewed PR description, changed files and inline comments. - The
view conversation on GitHublink can get lost in its current position when a PR has a long description and many changed files (particularly if the description has links at the bottom).
We could show the information in the following order:
- The title, number and branch of the PR
- Reviewers, review status and link to reviews
- The long description of the PR
- Changed file tree / links to inline comments
- Link to external
view conversation on GitHub
What do you think?