This repository was archived by the owner on Jun 21, 2023. It is now read-only.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Visual Studio 2017 deadlocks when a solution is opened #1520
Description
- GitHub Extension for Visual Studio version: 2.4.3 (dev)
- Visual Studio version: 2017
- Launched Visual Studio
- Opened a solution that is hosted on GitHub
- Visual Studio hangs/deadlocks
Found the following package load error in VS log for GitHubPackage:
I tried changing our GetService to use GetServiceAsync:
It appears MenuCommandService.AddCommand uses IServiceProvider.GetService and so must be called on the Main thread.
This was only an issue on Visual Studio 2017. It seems the PackageAutoLoadFlags.BackgroundLoad flag is only honored on Visual Studio 2017. When the package is auto-loaded on Visual Studio 2015, the package initialization is done on the Main thread.