GitHub pane appears blank when current repository is not a GitHub repo.

[grokys]

There are 3 situations we need to handle here:

1. There is no project loaded and the Team Explorer has source control context
2. There is a project loaded but it's not a git repository
3. There is a project loaded but it's not a GitHub repository

[shana]

Ayup.

[grokys]

@donokuda any idea what this should look like?

[donokuda]

We could go with the same approach as the logged out view in terms of layout.

I think we should use this as an opportunity to publish their repository to GitHub so they can start using what our extension offers immediately such as creating a pull request.

Here are some mocks to illustrate what I was thinking:

Here's an alternative version using the primary button styles because yey options!

That said, I'm curious if there's a way where we can ship this message without publishing as a first pass (because having something explaining why the pane is empty is better than nothing.) We could link to the "Create Repo" page, but I'm not sure how to bring the flow back to Visual Studio without making it feel "disconnected."

[donokuda]

PS. If there's a view already set up for this, I can stub something out for you 😄

[grokys]

Looks good to me! There's no view currently set up - will do that now.

[grokys]

@donokuda ok, there's a blank view on the fixes/356-not-a-github-repository branch at:

https://github.com/github/VisualStudio/blob/fixes/356-not-a-github-repository/src/GitHub.VisualStudio/UI/Views/NotAGitHubRepositoryView.xaml

Work your magic! 👾

[donokuda]

✨ 🎩 ✨

I added some content in 64ef6c6.

❓ Is the publish button the only thing needed for this flow? After looking at our create a repo modal, I think we'll want to ask for a name, description, and which account to add the repo to:

Is there something that exists for publishing an existing repo to GitHub in our extension? If so, it would be interesting to see if the publish button takes the user to that. If not, then that's something we should design.

Regardless, here's how it currently looks like!

[shana]

We already have a publish to github view in the Team Explorer area:

We can embed that in our pane or jump to it.

On a different note, I've been doing the PR creation and I'm finding the green button pretty hard to read. The white on flat green just disappears. It's also almost impossible to tell when it's enabled/disabled, too :/

[donokuda]

On a different note, I've been doing the PR creation and I'm finding the green button pretty hard to read. The white on flat green just disappears. It's also almost impossible to tell when it's enabled/disabled, too :/

Looked into this and it appears I have specified the wrong green hex for some reason... facepalmpicard.jpg

I'll open up a PR to fix this!

[grokys]

This was fixed by #374 - are we OK to close it?