This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Make sure our assemblies are lazily loaded #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazily load `IPullRequestSessionManager` in `InlineCommentMarginProvider` to prevent loading the kitchen sink on VS startup.
Was causing Rx to get loaded everywhere.
To prevent `GitHub.App` being loaded when Team Explorer shown.
So that `GitHub.App` is only loaded when actually needed.
grokys
force-pushed
the
fixes/1387-lazy-load-assemblies
branch
from
71cb217 to
fb88c3e
Compare
|
This has broken logging in because we're now trying to get the |
|
LGTM too |
jcansdale
previously approved these changes
Dec 19, 2017
We need to make sure we're on the main thread to get an instance of `ITwoFactorChallengeHandler`. This is nasty and the whole thing needs to be refactored; see #1398.
jcansdale
approved these changes
Dec 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes our lazy loading of assemblies. Previously all assemblies were loaded on VS startup (with Team Explorer and GitHub pane not shown):
Following this PR the list now looks like:
Note that this only fixes things to the state they were before. ReactiveUI is still used by
GitHubConnectSectionwhich in VS2017 is the default view in team explorer, meaning that RxUI gets loaded as soon as Team Explorer loads in VS2017. We should fix this, but it's a different PR I think.Fixes #1387