Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Fix PullRequest TreeView Keyboard navigation #1417

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Fix PullRequest TreeView Keyboard navigation #1417

merged 2 commits into from
Jan 11, 2018

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Jan 11, 2018 •
edited
Loading

Fixes #1416

  • Repair keyboard directional navigation
    • Setting DirectionalNavigation to None on TreeViewItem contents allows standard TreeView navigation
  • Performing the default operation of DoDiffFile on Enter

@StanleyGoldman StanleyGoldman force-pushed the fixes/tree-view-keyboard-navigation branch from b438544 to 05362a2 Compare January 11, 2018 18:04
jcansdale
jcansdale reviewed Jan 11, 2018
View reviewed changes
Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if hitting enter would perform the default action (View Changes). This is how the Solution Explorer and Team Explorer tree views work (e.g. the Team Explorer - Changes view).

jcansdale
jcansdale approved these changes Jan 11, 2018
View reviewed changes
Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work great! :-)

@jcansdale jcansdale merged commit 7a663a6 into master Jan 11, 2018
@jcansdale jcansdale deleted the fixes/tree-view-keyboard-navigation branch January 11, 2018 19:06
grokys added a commit that referenced this pull request Jan 12, 2018
@grokys
Ported changes from #1417 to PullRequestFilesView.
965af37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jcansdale jcansdale jcansdale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanleyGoldman @jcansdale