Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented Mar 27, 2018

Adds two new metrics:

  • NumberOfPRReviewDiffViewInlineCommentStartReview: incremented when the "Start Review" button is clicked from an inline comment
  • NumberOfPRReviewPosts: incremented when a PR review is submitted

Depends on #1562
Part of #1491

Adds two new metrics:

- `NumberOfPRReviewDiffViewInlineCommentStartReview`: incremented when the "Start Review" button is clicked from an inline comment
- `NumberOfPRReviewPosts`: incremented when a PR review is submitted
@meaghanlewis
Copy link
Contributor

These metrics look good to me! Tested on VS2015 & VS2017

@drguthals
Copy link

The first time I started a review from a diff and submitted that review it did not get recorded. I've tried twice since then and it worked. I'm going to try re-starting my experimental instance to see if the first one works when I re-start.

@drguthals
Copy link

Tests:
2015 Dogfood:

  • responding to a comment to start a review did not cause the comment to remain open
  • all metrics were updated

2015 Experimental:

  • responding to a comment to start a review did not cause the comment to remain open
  • all metrics were updated
  • This time I submitted as comment only and it increased numberOfPRReviewPosts - which I believe is intended behavior, I just wanted to make sure 👍

2017 Experimental:

  • responding to a comment to start a review did not cause the comment to remain open
  • all metrics were updated
  • This time I submitted as approved and it still worked 👍

Copy link

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing that one bug. I have not been able to repro the first time that my metrics weren't updated, but I'm going to assume that was just funky with me for now.

@hubot hubot requested a deployment to production March 29, 2018 09:05 Abandoned
@jcansdale jcansdale changed the base branch from feature/pr-review-authoring to feature/pr-reviews-master April 9, 2018 16:39
@jcansdale jcansdale force-pushed the feature/pr-review-metrics branch from 3ba7773 to 4e69c17 Compare April 9, 2018 16:49
@jcansdale jcansdale merged commit b4cf1d0 into feature/pr-reviews-master Apr 9, 2018
@jcansdale jcansdale deleted the feature/pr-review-metrics branch April 9, 2018 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants