Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented Apr 5, 2018

Addresses this request in #1570:

Could we make it so you can click on either the avatar or the ✔️ / 💬? #1523 (comment)

This makes the avatar in the "Reviewers" section clickable; when clicked it navigates to the user's reviews:

image

Depends on #1585
Part of #1491

Copy link
Contributor

@donokuda donokuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes in 02427b6 and it looks good to me.

Also pulled it down and tested the branch locally 👍

@meaghanlewis
Copy link
Contributor

LGTM 👍

@jcansdale jcansdale changed the base branch from feature/pr-reviews-master to feature/pr-reviews April 10, 2018 11:05
@jcansdale jcansdale changed the base branch from feature/pr-reviews to feature/pr-reviews-master April 10, 2018 11:06
@jcansdale jcansdale merged commit cef9124 into feature/pr-reviews-master Apr 10, 2018
@jcansdale jcansdale deleted the fixes/make-review-avatar-clickable branch April 10, 2018 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants