This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix crash after publishing new repository #188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio crashed after publishing, but the publishing process completed before the crash. A call was made to a disposed object after the view changed, causing the disposal.
|
Yay race conditions 😢 |
|
I'm going to fix this in a separate PR, as it requires a bit more logic to make sure it doesn't fail. Thanks for the help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio crashed after publishing, but the publishing process completed before the crash. The completion.OnNext() subscriber changes the active UI, which disposes the UIController. The subsequent completion?.OnCompleted() call threw an exception because completion is not null, but it is disposed. Since the OnNext subscriber is not evaluating the parameter, I changed the subscriber to respond to the OnCompleted() event instead. This appears to fix the issue.