This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Remove trackingcollection #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only used in `RepositoryCreationViewModel` ,where it was failing to properly sort the items in the UI (recommended items weren't getting placed at the top) and was causing intermittent test failures.
When akavache refreshes its cache, duplicate items are produced. This should really be fixed at a lower level, but for the moment just remove duplicates in the view model. Also fix sorting.
The funtionality tested by this test was only needed in the context of `TrackingCollection.
grokys
force-pushed
the
refactor/remove-trackingcollection
branch
from
9c771fd to
49c2697
Compare
|
This works well for me 👍 |
jcansdale
approved these changes
Nov 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrackingCollectionwas originally written to display the Pull Request list without locking up the UI, however in #1737, we moved to using data virtualization, which meant we no longer useTrackingCollection.The remaining place in which tracking was used was the PR creation dialog, however
TrackingCollectionwas not acting correctly and causing #2054, in addition a few of theTrackingCollectiontests frequently came up as flaky tests, failing our CI build.The issue in the PR creation dialog was more easily fixed by transitioning to using simple LINQ, so this PR removes the class.
Fixes #2054