This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Use default refspec when fetching #2344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch(Remote remote, FetchOptions options) was removed so we need a way to use the default refspec. This is done by passing an empty array of refspecs.
StanleyGoldman
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Fetch(Remote remote, FetchOptions options)method was removed in the latest version ofLibGit2Sharp. We need an alternative way to specify that the default refspec (from.git\config) should be used.What this PR does
Network.Fetchinstead of defaulting to+refs/heads/*:refs/remotes/origin/*Diagnosis
The extension was making two calls to the following method, one with
remoteNameset tooriginand another with the name of the externally contributed pull request owner.This was causing the remote refs to change and the pull request detail pain would get stuck refreshing.
References
Fetch(Remote remote, FetchOptions options)methodlibgit2/libgit2sharp@825c0e8#diff-3298eb31ba8ca7b0c3458afc4fb58b6bL161
+refs/heads/*:refs/remotes/origin/*was made herehttps://github.com/github/VisualStudio/pull/2142/files#diff-3a3bdad543586b88e406637687688a85L84
Fixes #2343