Skip to content

Rust: Include tuple structs/variants in CallExprBase.getStaticTarget() #20621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

Rust: Include tuple structs/variants in CallExprBase.getStaticTarget() #20621

merged 1 commit into from
Oct 10, 2025
+9 −5

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 10, 2025 •
edited
Loading

This change means we now measure call resolution rates correctly. DCA confirms with an increased call resolution rate from 62.5 % to 74.85 %.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Oct 10, 2025
@hvitved hvitved force-pushed the rust/static-target-addressable branch from fe38a32 to 0fc2875 Compare October 10, 2025 07:48
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Oct 10, 2025
geoffw0
geoffw0 approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to seeing the DCA call target resolution stat 🤞

@hvitved hvitved marked this pull request as ready for review October 10, 2025 08:15
@hvitved hvitved requested a review from a team as a code owner October 10, 2025 08:15
@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 08:15
Copilot
Copilot AI reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@hvitved hvitved merged commit d842107 into github:main Oct 10, 2025
23 of 26 checks passed
@hvitved hvitved deleted the rust/static-target-addressable branch October 10, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees

No one assigned

Labels

no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hvitved @geoffw0