-
Notifications
You must be signed in to change notification settings - Fork 64.2k
Closed
Labels
actionsThis issue or pull request should be reviewed by the docs actions teamThis issue or pull request should be reviewed by the docs actions teamcontentThis issue or pull request belongs to the Docs Content teamThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem teamThis issue or pull request should be reviewed by the Docs Ecosystem teamhelp wantedAnyone is welcome to open a pull request to fix this issueAnyone is welcome to open a pull request to fix this issue
Description
What article on docs.github.com is affected?
This pertains to https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions. (I could have updated issue #825 but chose to make a new issue instead.)
What part(s) of the article would you like to see updated?
This issue has to do with the File pattern cheat sheet section of the article.
- The third sentence in the explanation of the meaning of
[]is "For example, the range[0-9a-f] matches any digits or lowercase letter." This, of course, is not true; it doesn't match "g" for example. Either the range should be changed to[0-9a-z], or the explanation should read "any digit or any of the lowercase lettersathroughf." Note that in any case, strictly speaking, it should read "any digit", not "any digits", although I doubt anyone will be particularly confused by "any digits." - In the Patterns to match branches and tags and Patterns to match file paths (sub)sections, all of the example matches appear to start with a hyphen. For example, the very first branch-matching pattern shown is
feature/*, and the example matches given appear to be-feature/my-branchand-feature/your-branch, which don't actually match the given pattern. I'm guessing that the initial hyphen is meant to serve the function of a bullet point and not meant to be considered as part of the matched text, but this is rather confusing, especially since the matches also contain internal hyphens. In some cases, hyphens appear at the start of the patterns themselves, but pattern examples such as-!README.mdsuggest that the hyphen is not meant as part of the pattern.
Metadata
Metadata
Assignees
Labels
actionsThis issue or pull request should be reviewed by the docs actions teamThis issue or pull request should be reviewed by the docs actions teamcontentThis issue or pull request belongs to the Docs Content teamThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem teamThis issue or pull request should be reviewed by the Docs Ecosystem teamhelp wantedAnyone is welcome to open a pull request to fix this issueAnyone is welcome to open a pull request to fix this issue