Skip to content

repo sync #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2020
Merged

repo sync #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2484cd3
Add external GitHub CLI product (#16277)
mattpollard Nov 3, 2020
50835f3
Branch was updated using the 'autoupdate branch' Actions workflow.
Octomerger Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/all-products.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ sortedProductIds.forEach(productId => {
})

const externalProducts = {
cli: {
id: 'cli',
name: 'GitHub CLI',
href: 'https://cli.github.com/manual',
external: true
},
atom: {
id: 'atom',
name: 'Atom',
Expand Down
3 changes: 2 additions & 1 deletion tests/rendering/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ describe('sidebar', () => {
expect($githubPage('.sidebar li.sidebar-product > a').text().trim()).toBe('GitHub.com')
})

test('includes links to external products like Atom and Electron', async () => {
test('includes links to external products like the CLI, Atom, and Electron', async () => {
expect($homePage('.sidebar a[href="https://cli.github.com/manual"]')).toHaveLength(1)
expect($homePage('.sidebar a[href="https://atom.io/docs"]')).toHaveLength(1)
expect($homePage('.sidebar a[href="https://electronjs.org/docs"]')).toHaveLength(1)
})
Expand Down