Skip to content

repo sync #15853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022
Merged

repo sync #15853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7301d
Fail on console.error in tests with failOnConsole (#25600)
rsese Feb 25, 2022
24f8606
Merge branch 'main' into repo-sync
Octomerger Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module.exports = {
},
reporters,
modulePathIgnorePatterns: ['assets/'],
setupFilesAfterEnv: ['@alex_neo/jest-expect-message'],
setupFilesAfterEnv: ['./jest.setup.js', '@alex_neo/jest-expect-message'],
...(isBrowser ? {} : { testEnvironment: 'node' }),
testPathIgnorePatterns: [
'node_modules/',
Expand Down
12 changes: 12 additions & 0 deletions jest.setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import failOnConsole from 'jest-fail-on-console'

// Jest tests don't fail in some cases where we would see an error in DevTools
// Console when running locally and we would also see the error in the test
// output. This includes the React `Each child in a list should have a unique
// "key" prop` error example.
//
// To catch this and fail tests in cases like this, we use `jest-fail-on-console`
// to fail on calls to `console.error()`.
failOnConsole({
shouldFailOnWarn: false,
})
47 changes: 47 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@
"japanese-characters": "^1.1.0",
"javascript-stringify": "^2.1.0",
"jest": "^27.4.7",
"jest-fail-on-console": "^2.2.3",
"jest-github-actions-reporter": "^1.0.3",
"jest-slow-test-reporter": "^1.0.0",
"linkinator": "^3.0.3",
Expand Down