Skip to content

Conversation

@cdwort
Copy link

@cdwort cdwort commented Jun 29, 2022

Why:

Addresses support ticket question. We forgot to ask folks to check this setting!

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adds a step to check dotfiles config for Codespaces.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Jun 29, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/troubleshooting/troubleshooting-dotfiles-for-codespaces.md fpt
ghec
fpt
ghec

@cmwilson21
Copy link
Contributor

@cdwort Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels Jun 29, 2022
hubwriter
hubwriter previously approved these changes Jul 1, 2022
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cdwort - that's a useful addition. 👍

@hubwriter hubwriter enabled auto-merge (squash) July 1, 2022 11:15
@hubwriter hubwriter added the ready to merge This pull request is ready to merge label Jul 1, 2022
@hubwriter hubwriter disabled auto-merge July 11, 2022 13:09
@hubwriter hubwriter enabled auto-merge (squash) July 11, 2022 13:09
@hubwriter hubwriter removed the waiting for review Issue/PR is waiting for a writer's review label Jul 11, 2022
@hubwriter
Copy link
Contributor

I don't have upload access to https://github.com/cdwort/docs to add the new image file to the repo, so I'm going to move this to the internal repo so that I can finish this off.

@hubwriter hubwriter closed this Jul 11, 2022
auto-merge was automatically disabled July 11, 2022 13:41

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants