Surround env variables with quotes #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-dunham
approved these changes
Nov 18, 2022
masoudahg00
referenced
this pull request
in masoudahg00/gh-actions-importer
Aug 14, 2025
0xe9e7CEA3DedcA5984780Bafc599bD69ADd087D560xeCDCB5B88F8e3C15f95c720C51c71c9E2080525d CGACCESSgT8YhWRK6H
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing?
This updates the
DockerServiceto surround--envoptions in quotes so that values containing spaces are valid.How's this tested?
NO_PROXY="localhost, 127.0.0.1, ::1, .XXX.de, .YYY.de" dotnet run --project ActionsImporter/ActionsImporter.csproj -- dry-run ...Closes #6