-
Notifications
You must be signed in to change notification settings - Fork 356
Bumped Kramdown to 1.9.0 #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+1 for this, block IALs for links and images (kramdown 1.6.0 and above) would be extremely handy. |
@Stargator Any interest in bringing this to 1.8.0? I've also sent this over for review to our security team. No estimates on when the review will be completed. Thanks for your patience! |
No problem @gjtorikian. I'll update by tomorrow. The wait isn't an issue either. I chose to polish up the branches during a vacation I had, so it just gave me stuff to do. Considering there have been a few changes to the master branch here, I'm not sure how to just update the branch without it trying to pull in all the changes. Or should I just create an update branch and up Kramdown to 1.8.0? I want to keep the commits that get pulled as simple as possible. |
I usually create a new branch with every change, so perhaps submit a new PR? |
Hard reset to the previous commit, pull from master, make the change. 👍 |
Updated to version 1.8.0. Thanks @pathawks that helped a lot. |
@Stargator Can you update the pull request description, too? To include 1.7.0 to 1.8.0 changes. |
@parkr Yes I can. 😄 |
Is there any news re: bumping this to 1.8.0? |
To be honest, this was 👍ed by security, I just haven't had a chance to bring it in yet due to other Life Events. Assigning it to myself so I don't forget. |
Hey guys, is it OK to merge this to |
@mstred it seems to be since @gjtorikian stated security gave the 👍 |
@mstred There's a little more legwork to be done on GitHub's side once Security gives the 🆗 . They'll get to it soon! |
Thanks @parkr for the clarification! |
Thank you all. I'll stay tuned. 👍 |
c56e93e
to
8d06499
Compare
I am reopening the pull request as I have updated it to Kramdown 1.9.0. I didn't intend to close it, it seems that was done automatically through Github's own monitoring process. |
Added this commit to the WIP Jekyll 3.0.x PR, and hope to be able to merge it as part of the 3.0.x bump to minimize the number of rounds of potential user-facing changes. |
@Stargator thanks for the pull request. Bumped by #180 in preparation for Jekyll 3.0.x, and now live. |
Changes that come with updating from 1.5.0 to 1.9.0
Changes from 1.9.0
Changes from 1.8.0
\texttt
instead of\tt
for code spans (fixes #257, reportedby richard101696)
footnote_backlink
for changing the backlink of footnotes in the HTML converter(fixes #247, requested by Benjamin Esham)
#253, requested by Michael Franzl)
by Gregory Pakosz)
or headers that appear in the table of contents (reported by Peter Kehl)
(reported by Christian Kruse)
backtracking in the regular expression engine - fixed by using atomic grouping (reported by Ali
Ok)
Changes from 1.7.0
This release brings among other things support for the ‘minted’ syntax highlighter for LaTeX and a new math engine based on MathJax-Node that outputs to MathML.
converter is now available (fixes issue #93, initial patch #242 by
l3kn)
MathML is now available (patch #240 by Tom Thorogood)
and patched by Dennis Günnewig)
kramdown --help
is now sorted.lib/kramdown/utils/configurable.rb
will not showanymore (reported by Robert A. Heiler)
rules as with inline links (reported by Josh Davis)
Changes from 1.6.0
This release contains many fixes and minor enhancements as well as one major goodie that comes with a small caveat: block IALs can now be applied to link and abbreviation definitions!
It may not sound like much but allowing block IALs to be applied to link definitions alleviates the problem that additional attributes could only be specified via span IALs. Now such attributes can be stored together with the URL and title at the link definition
from cabo)
#214, requested by BackOrder)
that back-references can be used (issue #195, requested by Ciro Santilli)
by winniehell)
Michael Franzl)
<img>
tags are now correctly handled by the kramdownconverter (reported by winniehell)
block (reported by Bill Tozier)
converter (reported by and pull request #206 from winniehell)
sometimes lead to LaTeX conversion errors