Remove gem-based themes, replace with remote themes #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YiMysty
approved these changes
Apr 26, 2021
3zrv
approved these changes
Jul 5, 2021
This was referenced Jul 24, 2021
hijaq
added a commit
to canadakaknado/canadakaknado.github.io
that referenced
this pull request
Jul 25, 2021
|
I just won't be needing these |
This was referenced Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the github-pages gem to remove the gem-based themes. These are quite a burden to keep up-to-date. It's much better to use jekyll-remote-theme which pulls down the theme on-demand. Folks can specify a new version if they like with
remote_theme: user/repo@revision. I think this will be more maintainable and it will reduce the number of dependencies forgithub-pages.