Making class cleanup work again

[amyschoen]

Deleting old student repos was no longer working with the refactor. This fix works for me. I pulled in some of the newer functions and the HTTPie library.

[parkerbxyz]

Thanks for your contributions, as always, @amyschoen! ✨

[parkerbxyz]

I also recommend updating the description on line 3 to be more clear about what this script does:

training-manual/script/clean-up-class

Line 3 in aaa670a

# Cleanup Class

[amyschoen]

@parkerbxyz, I did not know that function is technically less correct. Do we want to remove it everywhere and add that check to the linter? I just followed the same format that was elsewhere in the code.

I didn't modify the comment, but I'll get that fixed up. I'll wait on your answer for the script changes.

[parkerbxyz]

Do we want to remove it everywhere and add that check to the linter? I just followed the same format that was elsewhere in the code.

I’ve just been doing it as I’ve refactored specific scripts. Here are the scripts that have been refactored and no longer contain the function syntax:

• bootstrap
• create-files
• create-initial-repo
• create-practice-repos
• shared_functions
• teach-class

I wouldn’t worry about removing the syntax from the other scripts unless/until we have other changes to make to them. It has actually helped me keep track of which scripts have been refactored and which still need some attention.

[amyschoen]

ask isn't refactored yet, but i see your point. I'll get this fixed up. I still think we should add the check to the linter since it'll only flag this in modified scripts.

[amyschoen]

Thanks for the clean up @parkerbxyz. My day job got hectic, so I never quite circled back to fix this.

[yosselin-babel]

li

[yosselin-babel]

l

[amyschoen]

@parkerbxyz are we good to merge this one? Someone leaving junk comments made me realize this was still active. Looks like my permissions got bumped up because I now have the ability to merge, but I don't want to screw up any of your internal processes.

[yosselin-babel]

listo

[parkerbxyz]

@amyschoen Go ahead and merge whenever you’re ready. 🙂

[amyschoen]

🎉 My first merge to the repo. 😀