OAuth nickname to username

[ghost]

This uses the oauth nickname, when present, as the username.

Fix for issue #5813.
Replaces PR #5824.

For LDAP to work as expected, requires gitlabhq/omniauth-ldap#7 to be merged.

[ghost]

Should this have a config option to specify whether to even attempt using the nickname?

[ghost]

The Travis build error is unrelated.

[jvanbaarsen]

@randx What do you think?

[omkelderman]

I like this one :D, it makes single-sing-on from github a lot more logical (since you keep the same username).
One question though, ive figured out the nickname-thing myself, so i edited user.rb myself. Then i came across this page. Should i worry about the fact that i havent edited those other two files?? (ive absolutely no idea what the function of those files is:P)

[ghost]

@omkelderman The other two files are for tests. If you aren't doing GitLab development or running the tests, you don't need to worry about the other files.

[omkelderman]

@jhollingsworth Sweet :D and thanks for the quick answer!

[jvanbaarsen]

The dependency is met via: gitlabhq/omniauth-ldap#10

[jvanbaarsen]

What happens if auth.info is not present?

[dblessing]

auth.info should always exist in omniauth. See https://github.com/intridea/omniauth/wiki/Auth-Hash-Schema

[jvanbaarsen]

@dblessing Ok thanks :-)

[jvanbaarsen]

@jhollingsworth Can you please make it mergeable again?

[jvanbaarsen]

This merge request has been closed because a request for more information has not been reacted to for more than 2 weeks. If you respond and conform to the merge request guidelines in our contributing guidelines we will reopen this merge request.