cmd L support for OSX and text selection for (ctrl | cmd) L

[bogas04]

Fix for #159

[bogas04]

The combo box expands as soon as it gets the focus, this temporarily selects the text and then opens the popup!

[hrj]

Wow, that was fast!

I see that you are addressing OSX as well, and that is welcome. But can you try to push the OSX detection to a global level? You can do the detection in PlatformInit class, and then store the result in a flag / enum. This can help with other OSX issues such as #156.

[hrj]

You can factor out the common code like this:

  KeyStroke keystroke = 
    isOsX 
    ? KeyStroke.getKeyStroke(KeyEvent.VK_L, Toolkit.getDefaultToolkit().getMenuShortcutKeyMask())
    : KeyStroke.getKeyStroke("ctrl L");

  getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(keystroke, "edit URL");

[bogas04]

@hrj Thanks a lot for the suggestions! I was wondering where exactly I should put the enum.

BTW there's an issue, can you suggest what can be done about it? #161 (comment)

[bogas04]

@hrj I kind of screwed up, forgot I was in master branch all this while.

So the latest commit has :

• more OSX support
• that weird fix I was talking about for Issue progress bar goes beyond 100% #157 (comment)
• and the original fix of course

[hrj]

Since this mask is used in multiple places, you could define it in PlatformInit and call it CMD_CTRL_KS_MASK.

[bogas04]

Yeah, but I felt that it belongs to UX and PlatformInit might not be right place to have it there.

[hrj]

That's a good thought. Can you use ComponentSource to host the field then? That seems good enough for current set of changes.

If the mask gets used more widely, we can hoist it up to a larger class like PlatformInit later.

[hrj]

This is looking great, except for the hack for #157. Let's keep that separate.

About the branch, don't worry. We will use this PR for review and at the end of it, you can create a fresh branch, which is squashed and rebased on master.

[hrj]

Can you rename this to CMD_CTRL_KEY_MASK and update the comment to say "mask for keystroke"?

[hrj]

There is only one minor comment left to address. Rest all looks good.

When you are done, I can help you with rebasing and squashing the commits. Hit me up on Gitter or IRC.

[hrj]

Superseded by #163