Skip to content

Skip "parentsigned" check when the repo is empty #35292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2025
Merged

Skip "parentsigned" check when the repo is empty #35292

merged 1 commit into from
Aug 16, 2025

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Aug 16, 2025 •
edited
Loading

Fix #35280

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 16, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 16, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Aug 16, 2025

Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/35292/files?w=1

@wxiaoguang wxiaoguang mentioned this pull request Aug 16, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 16, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 16, 2025
@lunny lunny added backport/v1.24 This PR should be backported to Gitea 1.24 type/bug reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Aug 16, 2025
@lafriks lafriks merged commit 621f2fc into go-gitea:main Aug 16, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Aug 16, 2025
@GiteaBot
Copy link
Collaborator

GiteaBot commented Aug 16, 2025

I was unable to create a backport for 1.24. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 35292
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Aug 16, 2025
@wxiaoguang wxiaoguang deleted the fix-prepare-commit-sign branch August 16, 2025 16:34
@wxiaoguang wxiaoguang added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed backport/manual No power to the bots! Create your backport yourself! backport/v1.24 This PR should be backported to Gitea 1.24 labels Aug 16, 2025
@wxiaoguang wxiaoguang mentioned this pull request Aug 16, 2025
Closed
hiifong added a commit to hiifong/gitea that referenced this pull request Aug 18, 2025
@hiifong
Merge branch 'main' into squash-merge-msg
9ce1cae 
* main:
  [skip ci] Updated translations via Crowdin
  Fix LFS range size header response (go-gitea#35277)
  Skip "parentsigned" check when the repo is empty (go-gitea#35292)
  [skip ci] Updated translations via Crowdin
  Fix GitHub release assets URL validation (go-gitea#35287)
  nix flake use go1.25 (go-gitea#35288)
  go1.25.0 (go-gitea#35262)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 19, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b84a143 
* giteaofficial/main:
  Refactor smal code snippeds in models/issues/pull.go  (go-gitea#35301)
  fix: remove duplicate IDs (go-gitea#35210)
  Add start time on perf trace because it seems some steps haven't been recorded. (go-gitea#35282)
  nix dev shell add zip (go-gitea#35300)
  [skip ci] Updated translations via Crowdin
  Fix LFS range size header response (go-gitea#35277)
  Skip "parentsigned" check when the repo is empty (go-gitea#35292)
  [skip ci] Updated translations via Crowdin
  Fix GitHub release assets URL validation (go-gitea#35287)
  nix flake use go1.25 (go-gitea#35288)
  go1.25.0 (go-gitea#35262)
  fix nix dev shell on darwin (go-gitea#35278)
  Fix token lifetime, closes go-gitea#35230 (go-gitea#35271)
  OneDev migration: fix broken migration caused by various REST API changes in OneDev 7.8.0 and later (go-gitea#35216)
  [skip ci] Updated translations via Crowdin
  Fix font-size in inline code comment preview (go-gitea#35209)
  Fix a bug where lfs gc never worked. (go-gitea#35198)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

New repo new file crash

5 participants

@wxiaoguang @GiteaBot @lunny @delvh @lafriks