Skip to content

Added missing field #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Added missing field #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86c24d8
added missing field
DrMagPie Dec 7, 2020
03cee75
Updated Signature
DrMagPie Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github/github_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ func TestWebhooks(t *testing.T) {
filename: "../testdata/github/project-card.json",
headers: http.Header{
"X-Github-Event": []string{"project_card"},
"X-Hub-Signature": []string{"sha1=495dec0d6449d16b71f2ddcd37d595cb9b04b1d8"},
"X-Hub-Signature": []string{"sha1=f5ed1572b04f0e03c8d5f5e3f7fa63737bef76d7"},
},
},
{
Expand Down
15 changes: 8 additions & 7 deletions github/payload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2986,13 +2986,14 @@ type PingPayload struct {
type ProjectCardPayload struct {
Action string `json:"action"`
ProjectCard struct {
URL string `json:"url"`
ColumnURL string `json:"column_url"`
ColumnID int64 `json:"column_id"`
ID int64 `json:"id"`
NodeID string `json:"node_id"`
Note *string `json:"note"`
Creator struct {
URL string `json:"url"`
ProjectURL string `json:"project_url"`
ColumnURL string `json:"column_url"`
ColumnID int64 `json:"column_id"`
ID int64 `json:"id"`
NodeID string `json:"node_id"`
Note *string `json:"note"`
Creator struct {
Login string `json:"login"`
ID int64 `json:"id"`
NodeID string `json:"node_id"`
Expand Down
5 changes: 3 additions & 2 deletions testdata/github/project-card.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"action": "created",
"project_card": {
"url": "https://api.github.com/projects/columns/cards/1266091",
"project_url": "https://api.github.com/projects/6047634",
"column_url": "https://api.github.com/projects/columns/515520",
"column_id": 515520,
"id": 1266091,
Expand All @@ -27,7 +28,7 @@
},
"created_at": 1483569391,
"updated_at": 1483569391,
"content_url": "https://api.github.com/repos/baxterthehacker/public-repo/issues/2"
"content_url": "https://api.github.com/repos/baxterthehacker/public-repo/issues/2"
},
"repository": {
"id": 35129377,
Expand Down Expand Up @@ -145,4 +146,4 @@
"type": "User",
"site_admin": false
}
}
}