Skip to content

Conversation

@bnfinet
Copy link
Contributor

@bnfinet bnfinet commented Nov 25, 2018

Copy link
Collaborator

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bnfinet! acouple of minor requests and then it looks good to merge :)

@bnfinet
Copy link
Contributor Author

bnfinet commented Nov 28, 2018

Thanks for the reply. I've made the changes as requested. Please do let me know if there's any other adjustments necessary.

@bnfinet
Copy link
Contributor Author

bnfinet commented Dec 5, 2018

@joeybloggs do let me know if there's anything further here or if you're ready to merge the PR :)

@deankarn deankarn merged commit 8851570 into go-playground:v5 Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants