Skip to content

Global function tables: Vec instead of array, optional lazy loading #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2023
Merged

Global function tables: Vec instead of array, optional lazy loading #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b5977e
Use Vec instead of array for global function tables
Bromeon Oct 19, 2023
8402bd4
StringCache uses newer StringName constructor function for Godot >= 4.2
Bromeon Oct 20, 2023
4a59767
Add GdextBuild::{before_api, since_api}; fix itest depending on compi…
Bromeon Oct 21, 2023
f7f8853
Implement lazy function pointer loading, based on HashMap
Bromeon Oct 21, 2023
ea7b70e
CI: 3 new jobs with feature `godot/lazy-function-tables`
Bromeon Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/full-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ jobs:
- name: "Test"
run: cargo test $GDEXT_FEATURES ${{ matrix.rust-extra-args }}


# For complex matrix workflow, see https://stackoverflow.com/a/65434401
godot-itest:
name: godot-itest (${{ matrix.name }})
Expand Down Expand Up @@ -178,6 +179,13 @@ jobs:
godot-binary: godot.macos.editor.dev.x86_64
#godot-prebuilt-patch: '4.1'

# TODO merge with other jobs
- name: macos-lazy-fptrs
os: macos-12
artifact-name: macos-nightly
godot-binary: godot.macos.editor.dev.x86_64
rust-extra-args: --features godot/lazy-function-tables

# Windows

- name: windows
Expand All @@ -198,6 +206,13 @@ jobs:
godot-binary: godot.windows.editor.dev.x86_64.exe
#godot-prebuilt-patch: '4.1'

# TODO merge with other jobs
- name: windows-lazy-fptrs
os: windows-latest
artifact-name: windows-nightly
godot-binary: godot.windows.editor.dev.x86_64.exe
rust-extra-args: --features godot/lazy-function-tables

# Linux

# Don't use latest Ubuntu (22.04) as it breaks lots of ecosystem compatibility.
Expand All @@ -220,6 +235,13 @@ jobs:
godot-binary: godot.linuxbsd.editor.dev.x86_64
rust-extra-args: --features godot/custom-godot,godot/experimental-threads,godot/serde

# TODO merge with other jobs
- name: linux-lazy-fptrs
os: ubuntu-20.04
artifact-name: linux-nightly
godot-binary: godot.linuxbsd.editor.dev.x86_64
rust-extra-args: --features godot/lazy-function-tables

# Linux compat

- name: linux-4.1.1
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/minimal-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,13 @@ jobs:
godot-binary: godot.linuxbsd.editor.dev.x86_64
rust-extra-args: --features godot/custom-godot,godot/experimental-threads,godot/serde

# TODO merge with other jobs
- name: linux-lazy-fptrs
os: ubuntu-20.04
artifact-name: linux-nightly
godot-binary: godot.linuxbsd.editor.dev.x86_64
rust-extra-args: --features godot/lazy-function-tables

# Linux compat

- name: linux-4.0.4
Expand Down
1 change: 1 addition & 0 deletions godot-codegen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ categories = ["game-engines", "graphics"]
default = ["codegen-fmt"]
codegen-fmt = []
codegen-full = []
codegen-lazy-fptrs = []
double-precision = []
custom-godot = ["godot-bindings/custom-godot"]
experimental-godot-api = []
Expand Down
Loading