-
Notifications
You must be signed in to change notification settings - Fork 211
Add Flake for NixOS #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flake for NixOS #1069
Conversation
|
Relevant book page: https://godot-rust.github.io/gdnative-book/recipes/nix-build-system.html I'm not sure if the repo is the right place for this, especially now that we have it in two places (book + here). Could you elaborate more concretely how the existing Flake caused problems or what this improves? You mentioned brief pros/cons, but a bit more details would be nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You don't have a Flake. You have a suggested Nix shell that uses the system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the flake.lock file as well for reproducibility
Well, if you run a NixOs you can try the old one... iven cargo will have some problems because some out of date hardcoded deps, that is the point of the problem that i ran. The flake will do most of the work.
I`ll commit some improves and organization of the flake. EDIT: Sure, the root of the project isnt the best place for it, so i made the PR directly to the book. |
Updating the shell.nix to a flake.nix. See the Issue on gdnative for more understanding godot-rust/gdnative#1069 (comment)
Ah, right. I was confused by this, which implied an existing Flake 🙂
Thanks, also for the elaboration! I'll close this then, let's continue there. |
Edit bromeon: copied description from #1068
Case
So, after spending 4 whole days to make the bindgen and the gdnative work on my NixOs i came with a flake that i want to share.
i got fundamental help of my super NixOs-User @storopoli.
Flake
#jaoleal/Uni9Jogo@3dcc053
Its not perfect and theres some diferences of the official one in the book
Cons
Pros
Feel free to help improve it