Cherry-picks for the godot-cpp 4.4 branch - 1st batch #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2f6d7f2)
(cherry picked from commit 671e309)
People seem to want to build godot-cpp without any arguments, not even specifying a target. We have to detect if we are top level though because it conflicts with being consumed. (cherry picked from commit 8b33e73)
The SCons build doesn't do this, so neither should CMake Excpetions are already handled by DISABLE_EXCEPTIONS option (cherry picked from commit 43690cb)
Add GODOTCPP_TARGET configuration option Remove loop to generate the godot-cpp.<target> CMake Targets Rename test bindings target Update documentation (cherry picked from commit 89abe15)
(cherry picked from commit 0a73df5)
When attempting to generate XCode projects it would fail due to the target dependency chain not meeting expectations. This PR, adds the required dependency infomation so that the XCode generator works. (cherry picked from commit f83f364)
It should be ok when folders exist. Exception shouldn't be thrown. Update binding_generator.py It should be ok when folds exist. It will fail to build without this patch, in vs code on windows with compiler ( visual studio community 2022 amd 64) . Co-Authored-By: Chris Cranford <[email protected]> (cherry picked from commit d79959c)
Made all warnings private. Warning as error private Consistency in generator expressions (cherry picked from commit 5eb16d0)
dsnopek
added
bug
This was referenced Mar 17, 2025
Merged
paddy-exe
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1st batch of PR's marked with
cherrypick:4.4This is mostly cmake stuff, but not only.