Use Math::abs to avoid ambiguity with integer abs #1770
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
approved these changes
Apr 16, 2025
dsnopek
approved these changes
Apr 16, 2025
dsnopek
added
waiting for Godot
dsnopek
added
cherrypick:4.4
and removed
waiting for Godot
|
Cherry-picked for 4.4 in PR #1805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That happened when compiling with Clang on Linux and
-Wall: https://github.com/Zylann/godot_voxel/actions/runs/14474467053/job/40596573102