Fix classes without _to_string() always returning "[Wrapped:0]"
#1776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
dsnopek
force-pushed
the
fix-default-to-string
branch
from
d1a9c47 to
1195f70
Compare
Ivorforce
approved these changes
Apr 25, 2025
dsnopek
force-pushed
the
fix-default-to-string
branch
2 times, most recently
from
df8bbf9 to
78522f2
Compare
dsnopek
force-pushed
the
fix-default-to-string
branch
from
78522f2 to
f38c056
Compare
|
I made one more addition to this: |
|
Cherry-picked for 4.3 in PR #1803 |
|
Cherry-picked for 4.4 in PR #1805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find an issue for this, but it seems that the default
_to_string()for extension classes just always returns"[Wrapped:0]"which is not very helpful :-)This PR fixes it by moving the default
_to_string()implementation toObject, rather thanWrapped. And it makes the one onWrappedexplicitly always return"[Wrapped:0]"like it did before, but without all the code that made it look like it was doing something more sophisticated.