Skip to content

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 14, 2022

Fix build after godotengine/godot#58972.

Note: Also requires godot-headers sync to work. I guess it worth waiting for godotengine/godot#59140, which will also require headers sync (but should not break anything else).

@bruvzg bruvzg added the topic:gdextension This relates to the new Godot 4 extension implementation label Mar 14, 2022
@bruvzg bruvzg added this to the 4.0 milestone Mar 14, 2022
@akien-mga
Copy link
Member

Note: Also requires godot-headers sync to work. I guess it worth waiting for godotengine/godot#59140, which will also require headers sync (but should not break anything else).

We've been talking a few times about dropping the godot-headers submodule in this repository and directly vendoring the header and API .json. Might be time to actually do it now so that such changes are easier to coordinate.

@bruvzg bruvzg force-pushed the fix-after-expose-more-gdextension branch from e9b115d to 56c7e31 Compare March 15, 2022 11:35
@bruvzg bruvzg force-pushed the fix-after-expose-more-gdextension branch from 56c7e31 to 817efdd Compare March 15, 2022 11:43
@akien-mga akien-mga merged commit 7bcf579 into godotengine:master Mar 16, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:gdextension This relates to the new Godot 4 extension implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants