-
-
Notifications
You must be signed in to change notification settings - Fork 689
Update hashfuncs, add some missing math funcs. #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure why the CMake MSVC build is failing, the SCons one seems to pass. Any CMake guru that can help? |
tmp fix so pipelines work until godotengine#819 is merged
No idea how to fix the MSVC issue but given that it's failing with a syntax error in |
tmp fix so pipelines work until godotengine#819 is merged
If someone is motivated, I made #834 to get verbose output from the CMake builds to be able to compare the build flags used by SCons and by MSVC, both using VS 2019. CMake:
SCons:
Maybe one of those triggers the error. Either way, to unblock this I would suggest either trying to remove the |
My bet is on |
4a4ecdb
to
c2d58d5
Compare
04cf99f
to
409f99f
Compare
We probably want to test more than just them being able to compile, but this is a start.
Ensures user inclusion of windows.h do not define "min" and "max" macros.
409f99f
to
081d425
Compare
Including hashfuncs (or any
hash_*
template) was broken and causing build error due to missing functions.This PR re-synchronize the
hashfuncs
with upstream godot, adds some missing math funcstions, and includes allgodot_cpp/templates/*
headers in the test project (so we ensure they can at least be built).Note: We should probably re-synchronize the other templates too since I believe they are outdated but I'd rather do that in a separate PR.