getting_started/first_2d_game/05.the_main_game_scene #21
giscus[bot]
bot
Replies: 77 comments 140 replies
-
|
For the code to actually work, the timer need to be activated through: "func _on_start_timer_timeout():". However, to do so you need to head into the timer node(for the example above, it would be the StartTimer node on the left side of your screen under main in the scene) change tab from inspector to node on the right side of your screen and connect the timeout signal to the main node. Just right click the timeout signal(or double click it), a window will pop up and then left click the main node and press connect. Then do that for all three of the timers(StartTimer, ScoreTimer, MobTimer). (The code didn't work for me until I did this, so I dont know if its my personal issue or not but ill leave the solution here for future viewers) |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for this. I had one timer that wasn't connected. |
Beta Was this translation helpful? Give feedback.
-
This should not be necessary, since the StartTimer is manually started in the new_game() function. Maybe you didn't notice the last step of the tutorial, which is calling new_game() in _ready()?. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for this! |
Beta Was this translation helpful? Give feedback.
-
|
I'm using 4.5dev4 and I also had to enable Autostart before the mob appeared on my screen. MacBook Pro M2 Max |
Beta Was this translation helpful? Give feedback.
-
|
Enabling Autostart causes an issue later when testing out the Heads up Display. When you run the program you will see the HUD and about 2 seconds later a mob appears and the program crashes. |
Beta Was this translation helpful? Give feedback.
-
|
I'm having problems with the "$Player.start($StartPosition.position)", it gives "Invalid call. Nonexistent function 'start' in base 'Area2D (Player.gd)'? I was thinking it would be more like "$Player.position(...)" but that doesn't work either. |
Beta Was this translation helpful? Give feedback.
-
|
If you check the script on your Player (you can get to this by clicking on the scroll next to your Player node on your main scene) do you have a start function defined there? It should look like this: func start(pos):
position = pos
show()
$CollisionShape2D.disabled = false |
Beta Was this translation helpful? Give feedback.
-
|
I did not. I went back to check if it was in the instructions, and I seem to have missed that part. Oopsie. Thank you very much for helping. |
Beta Was this translation helpful? Give feedback.
-
|
@WldGeese brilliant. I guess I overlooked this code block as being a part of community notes. |
Beta Was this translation helpful? Give feedback.
-
|
In the testing phase, the creatures don't appear. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
i fixed problem, thanks for help |
Beta Was this translation helpful? Give feedback.
-
|
How did you fix the problem? I'm running into the same issue. I grabbed your git and it's not working either, so no idea what you did to fix it. |
Beta Was this translation helpful? Give feedback.
-
|
Figured out out. C# users must change the connections under the Node tab to C# nomenclature, not the default it provides you. For example: When connecting timeout() from MobTimer, ScoreTimer, StartTimer to Main, it will default to _on_mob_timer_timeout and so on. This needs to be changed to OnMobTimerTimeout(), and so on for the rest. If you are having this issue at this point, you will also need to go back into the Player class and change _on_body_entered to OnBodyEntered() |
Beta Was this translation helpful? Give feedback.
-
|
Actually, after testing, leave the () off at the end because Godot throws an error, or, if you've already created the script as guided, you can select the Pick button to the right of the text field when editing the connection, and then select the appropriate method. |
Beta Was this translation helpful? Give feedback.
-
|
C# users must change the connections under the Node tab to C# nomenclature, not the default it provides you. For example: When connecting timeout() from MobTimer, ScoreTimer, StartTimer to Main, it will default to _on_mob_timer_timeout and so on. This needs to be changed to OnMobTimerTimeout(), and so on for the rest. If you are having this issue at this point, you will also need to go back into the Player class and change _on_body_entered to OnBodyEntered() |
Beta Was this translation helpful? Give feedback.
-
|
Actually, after testing, leave the () off at the end because Godot throws an error, or, if you've already created the script as guided, you can select the Pick button to the right of the text field when editing the connection, and then select the appropriate method. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks! it worked for me! |
Beta Was this translation helpful? Give feedback.
-
This is crazy talk... please maybe an animation or a screenshot of what you're saying here? |
Beta Was this translation helpful? Give feedback.
-
It's just really confusing where this code should go. |
Beta Was this translation helpful? Give feedback.
-
|
Oh, I see.. at no point was I instructed to add Player as a sub node to Main... that's pretty confusing. |
Beta Was this translation helpful? Give feedback.
-
I stand corrected. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for live troubleshooting this. I went through the exact same thought process as you. |
Beta Was this translation helpful? Give feedback.
-
|
I completely skipped this step as well lol, thanks for speaking my confused thoughts out loud. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I keep getting the error "Invalid set index 'position' (on base: 'RigidBody2D (mob.gd)') with value of type 'PathFollow2D'. I'm new to Godot so I've got no idea what it means, it causes the game to crash after a couple seconds. Any help would be greatly appreciated. |
Beta Was this translation helpful? Give feedback.
-
|
If you haven't found the cause you may start a new project and go through the tutorial again. I had to restart a few times and every time I understand more and more of the code (and why it fails). |
Beta Was this translation helpful? Give feedback.
-
|
I had the same issue and the bug was in the line:
You just need to write it like this:
|
Beta Was this translation helpful? Give feedback.
-
|
I get this error: "player.gd:10 @ start(): Node not found: "CollisionShape2D" (relative to "/root/Main/Player")", so it doesn't run at all. I double checked and there is indeed a CollisionShape2D node underneath Player... What am I doing wrong? |
Beta Was this translation helpful? Give feedback.
-
|
I had the same mistake. Check on your Player if your "CollisionShape2D" is under your Player or under your "AnimatedSprite2D". For me it was under the sprite and not a child of the Player. If it is the case just move it under Player, save, and it should be ok. |
Beta Was this translation helpful? Give feedback.
-
|
I'm running into the same issue - I verified this by reparenting the CollisionShape2D node to the player but I'm still unable to run the game. What's weird is that it works just fine if I run the player scene by itself. I should note that my player scrippt is in GDScript while my Main script is in C# so I'm using the GD.Load method to load the player script so that could be related. In case anyone tried to experiment with this, I will update my findings to see if this is the cause. |
Beta Was this translation helpful? Give feedback.
-
|
I just figured out the problem that currently has no workaround. It's related to this issue discussed below. It seems that while cross-language scripting works, inheritance does not. So when the engine looks for CollisionShape2D child of the player.gd in a C# context, it will throw the null pointer. While this is out of scope for the tutorial, I'm glad I learned this lesson. Inheritance Issue: godotengine/godot#38352 |
Beta Was this translation helpful? Give feedback.
-
|
Hi, newbie here trying to get tutorial working. Godot version 4.3 stable in question. "Script inherits from native type 'RigidBody2D', so it can't be assigned to an object of type: 'AnimatedSprite2D' Tried to find out if anyone else has this problem but no luck. |
Beta Was this translation helpful? Give feedback.
-
|
hi, confirm the Mob is type RigidBody2D. link found this, hope it helps |
Beta Was this translation helpful? Give feedback.
-
|
I was following along pretty well but I´m a bit lost on the _on_mob_timer_timeout function. My questions are:
The rest of the tutorial is amazing. Thank you for the excellent work you put into it. |
Beta Was this translation helpful? Give feedback.
-
|
add_child() is a method of the Node class, it adds a child node. You can right click the name "add_child()" in the code editor and select "Lookup symbol" which opens the documentation directly in the editor - really neat feature. |
Beta Was this translation helpful? Give feedback.
-
|
queue_free() sends the node into a queue to be deleted at the end of the current frame (per the docs). It could probably use a better name. "free" as in "free the memory allocation", or in human-speak "delete". |
Beta Was this translation helpful? Give feedback.
-
|
PI == 180 degrees, so PI/4 == 45 degrees. The tutorial has you set the rotation of the mob at 90 degrees relative to the path that represents the level boundary. So imagine the mob is spawning on the right-side wall. It would by default be pointing directly left. Adding this range of (-45 to +45 degrees) will turn its direction somewhat up, or down, randomly. This is what results in the random direction effect. |
Beta Was this translation helpful? Give feedback.
-
|
Regarding PI/4 and PI/2: As the docs mention you can use degrees instead and convert to radians, which is more intuitive in my opinion. You can replace the following code: with Same thing when randomizing the rotation of the mobs. can be replaced with: |
Beta Was this translation helpful? Give feedback.
-
|
When you have doubts about any of Godot's built-in methods or members, remember that you can Ctrl+click it on the editor to access the offline documentation! It's one of Godot's coolest features imo. |
Beta Was this translation helpful? Give feedback.
-
|
Something odd with Godot 4.3 on Mac Sequoia (not verified with other platforms). The game starts and plays as expected but the MobTimer stops firing after a random number of mob instances has been created and freed. Eventually the player is left on the screen with no more mob instances and I have to quit the game. I added prints to verify this. |
Beta Was this translation helpful? Give feedback.
-
|
:-D Ha! By adding a print statement in the game_over method, I found that I had actually been getting hit by a mob entity! Since there is no feedback yet... I was thinking that I had successfully dodged the creep :-D My bad :-( |
Beta Was this translation helpful? Give feedback.
-
|
so its not working when i put hide() in the player script on _ready the player never pops back up. When I put new_game() in the _ready function in Main the game crashes and I get 3 errors about unused parameters these include: _process function delta parameter in main.gd Even when new_game() is taken out of the ready function in main.gd the game runs with an empty window just a blank grey screen. Please Help. |
Beta Was this translation helpful? Give feedback.
-
|
_process function delta... this is because you have not removed the parts that are added by default. This part: _on_body_entered... there is a suggestion to use "_body" instead of "body". You can change it if you want to. None of these is a reason for the code to fail (they are in yellow). In my case I had missed the brackets and had "new_game" instead of "new_game()". You are missing something, but can't say what. Maybe start again. |
Beta Was this translation helpful? Give feedback.
-
|
I'm confused and stuck at _on_mob_timer_timeout. I copy and pasted the code into the main script but can't see the creatures. Using GDScript. |
Beta Was this translation helpful? Give feedback.
-
|
Do you have the "$MobTimer.start()" ? A mob should appear at timeout, but if it doesn't start, then there is no timeout. |
Beta Was this translation helpful? Give feedback.
-
|
I had to add
|
Beta Was this translation helpful? Give feedback.
-
|
Mob timer and Start timer start after Start timer expires (one shot is ON). If you have high value for Start timer, then it will take a while for Mob timer and Start timer as well. |
Beta Was this translation helpful? Give feedback.
-
|
To elaborate on comments above and in the code on how Imagine that the path drawn is a clockwise race car track where the start/finish line is point 1 (the upper-left corner, where we started drawing the path). When an imaginary race car is on any point of the track, it's pointing in the "forward" direction of the track. As the race car is going along the track, it's progressing along from 0 to 100% of the track... (or a ratio 0.0 to 1.0).
Node ... is setting the race car location to a random amount of "progress" along the track (or lap). Its direction is pointing "forward" for its position on the track. To change the direction to point inward, (which is on the race car's right side), we first rotate it +90 degrees (
|
Beta Was this translation helpful? Give feedback.
-
|
I do not have the 'hit' scene. Even without filter 'hit' I cannot find it anywhere in the scenes. https://ibb.co/vjnyDM2 |
Beta Was this translation helpful? Give feedback.
-
|
I checked twice and it was there. I think that something went wrong with the copying of the node and data. It looks connected, but it does not appear. I started doing the tutorial from scratch and I passed that stage. I have other troubles now, but I will try to figure it on my own first. |
Beta Was this translation helpful? Give feedback.
-
|
(is there an Edit or Delete function here?) |
Beta Was this translation helpful? Give feedback.
-
Yes, but it's not exposed on the Giscus web interface. You need to go to the GitHub Discussions page instead, log into GitHub, then use the Edit button that's hidden behind the 3 dots icon in the top-right corner of your comment. The same goes for deleting a post. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you, you're great! |
Beta Was this translation helpful? Give feedback.
-
|
Make sure your |
Beta Was this translation helpful? Give feedback.
-
|
Hello Together, i'm trying to recreate the c# part of the tut, but i'm facing the problem that i can't spawn any mobs. I already double checked the code with the repo, but i cant get it to work. Best Regards |
Beta Was this translation helpful? Give feedback.
-
|
If anyone wants the mobs to actually be launched towards the player, you can do this: var mob: RigidBody2D = mob_scene.instantiate()
var player: Area2D = $Player
var mob_spawn_location: PathFollow2D = $MobPath/MobSpawnLocation
mob_spawn_location.progress_ratio = randf()
mob.position = mob_spawn_location.position
var direction: Vector2 = mob.position.direction_to(player.position)
var speed = randf_range(150.0, 250.0)
mob.linear_velocity = direction * speed
mob.rotation = Vector2.RIGHT.angle_to(direction)
add_child(mob) |
Beta Was this translation helpful? Give feedback.
-
|
I just redrew my Path2D counterclockwise and it worked. The tutorial says to do it clockwise, but when I do it counterclockwise it worked just fine. |
Beta Was this translation helpful? Give feedback.
-
|
Question: Is this not supposed to be randomly spawning mobs from all around the edge of the arena? Because if so, it's not doing so; everything's coming from the upper-left corner. |
Beta Was this translation helpful? Give feedback.
-
|
There's something wrong with your code, could you post it? |
Beta Was this translation helpful? Give feedback.
-
|
Whoops! Hold on, lemme figure out how to do this... extends Node
@export var mob_scene: PackedScene
var score
func _ready():
pass
func game_over() -> void:
$ScoreTimer.stop()
$MobTimer.stop()
$HUD.show_game_over()
func new_game():
score = 0
$HUD.update_score(score)
$HUD.show_message("GET READY!")
$Player.start($StartPosition.position)
$StartTimer.start()
func _on_mob_timer_timeout() -> void:
# Create a new instance of the Mob scene.
var mob = mob_scene.instantiate()
# Choose a random location on Path2D.
var mob_spawn_location = $MobPath/MobSpawnLocation
# Set the mob's position to the random location.
mob.position = mob_spawn_location.position
# Set the mob's direction perpendicular to the path direction.
var direction = mob_spawn_location.rotation + PI/2
# Add some randomness to the direction.
direction += randf_range(-PI / 4, PI / 4)
mob.rotation = direction
# Choose the velocity for the mob.
var velocity = Vector2(randf_range(150.0, 250.0), 0.0)
mob.linear_velocity = velocity.rotated(direction)
# Spawn the mob by adding it to the Main scene.
add_child(mob)
func _on_score_timer_timeout() -> void:
score += 1
$HUD.update_score(score)
func _on_start_timer_timeout() -> void:
$MobTimer.start()
$ScoreTimer.start()That's what I currently have in place for the Main scene. I could have sworn I'd followed the tutorial exactly, but I guess I'd missed something. |
Beta Was this translation helpful? Give feedback.
-
|
Here's the issue: # Choose a random location on Path2D.
var mob_spawn_location = $MobPath/MobSpawnLocationContrary to what your comment says, you are not actually picking a random location. Here you're just assigning the Here's the missing line: mob_spawn_location.progress_ratio = randf()It assigns a random Hope that helps! |
Beta Was this translation helpful? Give feedback.
-
|
wince Oh, man. I'm sorry, I don't know how I managed to miss that. Thank you very much! |
Beta Was this translation helpful? Give feedback.
-
|
I'm not sure if anyone else also faced this issue but when using
There would be a weird thing where my path2D node and the mobs spawning were out of sync. So no matter what the shape and scale of the Path2D was like, the mobs would continue to spawn in a weird manner nowhere near my path node. I realized after a bit of debugging that you'd actually want the global position if you wanted the mobs to be bound to the Path2D node like I wanted and learnt the very important difference between local and global positions. So it'd be something like:
|
Beta Was this translation helpful? Give feedback.
-
I started the timeout codes and I've been getting these error messages and I don't know what to do |
Beta Was this translation helpful? Give feedback.
-
|
It's because you have multiple functions with the same name, just like the error says |
Beta Was this translation helpful? Give feedback.
-
|
Ah, thank you! Whenever I have to write new code, I often make a new line and type as I see it and not notice that the function already exists. Now I have an error involving the new game function and not finding the player node |
Beta Was this translation helpful? Give feedback.
-
I have solved my last code problem and now I'm having problems with testing the game. |
Beta Was this translation helpful? Give feedback.
-
|
What does your file structure look like? The error is saying essentially that it cannot find the referenced file in the root location. |
Beta Was this translation helpful? Give feedback.
-
|
Here is my structure so far |
Beta Was this translation helpful? Give feedback.
-
|
The player is working and now there's a problem with the mobspawn location |
Beta Was this translation helpful? Give feedback.
-
|
Looks like the same error type, it can't find the file it is supposed to be running, it's looking in the root folder for your file but not finding it. |
Beta Was this translation helpful? Give feedback.
-
|
What is your node structure |
Beta Was this translation helpful? Give feedback.
-
|
Men, I don't have any idea what to do with it. I spend some hour or two to "code" and now I'm stuck on this issue: |
Beta Was this translation helpful? Give feedback.
-
|
Okey. just my MobSpawnLocation should be PathFollow2D not Path2D... |
Beta Was this translation helpful? Give feedback.
-
|
Okay, I don't know why but as soon as I launch the game, all I see is one mob falling, then I don't see any other mod, and I don't know why but I guess maybe gravity? I'm stuck and really need help with this one. I'd really appreciate the help. |
Beta Was this translation helpful? Give feedback.
-
|
It sounds like the mob is being pulled down by gravity. Open the Mob scene, select the Mob node, and in the Inspector set: This disables gravity for the mob so it will move only with the velocity set in code and won’t fall off the screen. 
|
Beta Was this translation helpful? Give feedback.
-
Grey Screen? Check Your Main Scene!I ran into an issue where the game started but only showed a grey screen. To fix this I went to: and changed Main Scene to: 
After that the game ran correctly. |
Beta Was this translation helpful? Give feedback.
-
|
Whenever i try to run my code i get an error message |
Beta Was this translation helpful? Give feedback.
-
|
I am also experiencing this issue. Any assistance would be great! =) |
Beta Was this translation helpful? Give feedback.
-
|
I figured it out! I must've not fully completed this step: Click the Main node and you will see the Mob Scene property in the Inspector under "Main.gd". You can assign this property's value in two ways: Drag mob.tscn from the "FileSystem" dock and drop it in the Mob Scene property. Click the down arrow next to "[empty]" and choose "Load". Select mob.tscn. Game works perfectly now. |
Beta Was this translation helpful? Give feedback.
-
|
In C# ,for preventing issue, and to have the mobs to spawn i had to change the type for the mob instance: private void OnMobTimerTimeout()
{
RigidBody2D mob = MobScene.Instantiate<RigidBody2D>();
var mobSpawnLocation = GetNode<PathFollow2D>("MobPath/MobSpawnLocation");
mobSpawnLocation.ProgressRatio = GD.Randf();
float direction = mobSpawnLocation.Rotation + Mathf.Pi / 2;
mob.Position = mobSpawnLocation.Position;
direction += (float)GD.RandRange(-Mathf.Pi / 4, Mathf.Pi / 4);
mob.Rotation = direction;
var velocity = new Vector2((float)GD.RandRange(150.0, 250.0), 0);
mob.LinearVelocity = velocity.Rotated(direction);
AddChild(mob);
} |
Beta Was this translation helpful? Give feedback.
-
|
In fact the error was elsewhere. The Mob Root node has not the Mob.cs script attached to it. |
Beta Was this translation helpful? Give feedback.
-
|
Hi! |
Beta Was this translation helpful? Give feedback.
-
|
I can add that if I check the autostart box in the inspector, mobs are working, but it should be instantiated by the script, I have checked the signals for all timers and they are setup correclty. |
Beta Was this translation helpful? Give feedback.
-
|
I found the issue, now I feel dumb haha, on new_game() I did: When it should be $StartTimer instead of $ScoreTimer. Well, at least it forced me to check all the code and trace it, so now I understands it a bit more! :) |
Beta Was this translation helpful? Give feedback.
-
|
For anyone that enforces Unsafe Property Access or Unsafe Method Access you'll get an error when trying to access the Player scene that the start() function doesn't exist. You need to define a class for the player. I did this by just adding it under extends like so: extends Area2D
class_name AlienPlayerThen when you reference it in your main script like so: @onready var player: AlienPlayer = $Player |
Beta Was this translation helpful? Give feedback.
-
|
I have two questions, firstly, why do we set the mob_scene variable as an export to the global UI and then call the mob scene in the UI rather than setting the mob scene as a child of main and then using get_node to call it and then instantiate it? |
Beta Was this translation helpful? Give feedback.
-
|
Okay I have realized that MobSpawnLocation is the name of path2dfollow. But still would like an answer to the first question |
Beta Was this translation helpful? Give feedback.
-
|
Guys, please check the spellings of the node names you are giving , otherwise it will give null error. |
Beta Was this translation helpful? Give feedback.
and others
Uh oh!
There was an error while loading. Please reload this page.
-
getting_started/first_2d_game/05.the_main_game_scene
Now it's time to bring everything we did together into a playable game scene. Create a new scene and add a Node named Main. (The reason we are using Node instead of Node2D is because this node will...
https://docs.godotengine.org/en/latest/getting_started/first_2d_game/05.the_main_game_scene.html
Beta Was this translation helpful? Give feedback.
All reactions