Update 3D lights and shadows documentation for 4.0 #6355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
skyace65
requested changes
Nov 5, 2022
Contributor
skyace65
left a comment
skyace65
left a comment
There was a problem hiding this comment.
Overall this looks very good, just needs a few changes.
Calinou
force-pushed
the
update-3d-lights-and-shadows-4.0
branch
2 times, most recently
from
870eaca to
04c1722
Compare
mhilbrunner
approved these changes
Nov 8, 2022
Calinou
force-pushed
the
update-3d-lights-and-shadows-4.0
branch
from
04c1722 to
d4b5f1f
Compare
skyace65
added
the
area:manual
Calinou
force-pushed
the
update-3d-lights-and-shadows-4.0
branch
from
d4b5f1f to
f89ffb2
Compare
Calinou
force-pushed
the
update-3d-lights-and-shadows-4.0
branch
3 times, most recently
from
e4cd868 to
4dcbe85
Compare
clayjohn
reviewed
Feb 24, 2023
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Amazing work! Just a few comments. This is nearly ready to merge
Calinou
force-pushed
the
update-3d-lights-and-shadows-4.0
branch
4 times, most recently
from
0da1588 to
bc3f3ac
Compare
clayjohn
approved these changes
Feb 27, 2023
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Great work! Looks good to me
Calinou
force-pushed
the
update-3d-lights-and-shadows-4.0
branch
from
bc3f3ac to
ccb6693
Compare
Member
|
Can be rebased to fix warnings now that the page on decals was merged. Edit: Pushed myself. |
akien-mga
force-pushed
the
update-3d-lights-and-shadows-4.0
branch
2 times, most recently
from
eaae04b to
9189aa3
Compare
akien-mga
force-pushed
the
update-3d-lights-and-shadows-4.0
branch
from
9189aa3 to
50b86d7
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.