Skip to content

Conversation

@jasonjmcghee
Copy link
Contributor

@jasonjmcghee jasonjmcghee commented May 28, 2023

The code in C# examples for Compute Shaders page don't actually compile.

Updated to work:

  • Spirv -> SpirV
  • outputBuffer -> buffer
  • Can't directly print arrays - need to join as a string.

Output after updates in this patch:

Input: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
Output: 2, 4, 6, 8, 10, 12, 14, 16, 18, 20

Modifies the original work submitted in: #6159

The code in C# examples doesn't actually compile. Updated to work.
@jasonjmcghee jasonjmcghee changed the title Update compute_shaders.rst C# code snippets to compile Fix compute_shaders.rst C# code snippets to compile May 28, 2023
@raulsntos raulsntos added bug topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels May 29, 2023
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for contributing to the C# documentation.

@mhilbrunner mhilbrunner merged commit d37226e into godotengine:master May 29, 2023
@mhilbrunner
Copy link
Member

Thanks for contributing to C# docs and congrats on your first merged PR in this repository! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:dotnet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants