Fix mention of Godot3's or_lesser for export_range #7630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yes, it also applies to C#. The C# export attributes use the same hint strings than whatever Core defines. Thank you for also updating the C# documentation! |
raulsntos
added
bug
topic:dotnet
topic:gdscript
area:manual
raulsntos
approved these changes
Jul 8, 2023
skyace65
approved these changes
Jul 9, 2023
Contributor
|
Thanks! And congrats on your first merged PR! |
Contributor
Author
|
Thank you for merging it - that was surprisingly painless :) |
mhilbrunner
pushed a commit
that referenced
this pull request
Aug 1, 2023
Fix mention of Godot3's or_lesser for export_range
mhilbrunner
pushed a commit
that referenced
this pull request
Aug 1, 2023
Fix mention of Godot3's or_lesser for export_range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this page: https://docs.godotengine.org/en/latest/tutorials/scripting/gdscript/gdscript_exports.html#limiting-editor-input-ranges
The docs say to use the keyword "or_lesser" for ranges that can go below what is specified. This was changed in Godot4 and therefore should be "or_less"
I have also updated the C# version (I am assuming they were both changed, but I have not tested this)
This might need to be backported to previous doc versions?