Skip to content

Conversation

@FrederickKDP
Copy link
Contributor

@FrederickKDP FrederickKDP commented Jul 29, 2023

Update documentation to reflect the newest multiplayer API changes. In specific, multiplayer methods from get_tree() were moved to get_multiplayer(). It is possible to use get_tree().get_multiplayer(), but I find that would be overly verbose. In addition, not all code updates here were tested. Feedback appreciated.

YuriSizov and others added 5 commits June 28, 2023 17:36
classref: Sync with current 4.1 branch (6884be6)
Update documentation to reflect the newest multiplayer API changes. In specific, multiplayer methods from get_tree() were moved to get_multiplayer(). It is possible to use get_tree().get_multiplayer, but I find that would be overly verbose.
In addition, not all code updates here were tested. Feedback appreciated.
@AThousandShips
Copy link
Member

AThousandShips commented Jul 29, 2023

This is unfortunately already tracked in #7675, also in the future you should target master not 4.1, changes can then be cherry picked, see here

@FrederickKDP
Copy link
Contributor Author

Thank you! I will do! Glad it was already reported.

@FrederickKDP FrederickKDP changed the base branch from 4.1 to master July 29, 2023 08:47
@AThousandShips
Copy link
Member

What I mean is that there is already a PR open for this, this is a duplicate

@FrederickKDP FrederickKDP deleted the patch-2 branch July 29, 2023 08:48
@FrederickKDP
Copy link
Contributor Author

Closed. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants