Skip to content

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Feb 1, 2024

Add link to open-source web based alternative of BMFont editor

@AThousandShips
Copy link
Member

You should target master not 4.2, changes can then be cherry picked, see here.

If you need more information about the update process please see: here. If wanted I can fix the branch for you.

@dustdfg dustdfg changed the base branch from 4.2 to master February 1, 2024 17:13
@AThousandShips
Copy link
Member

AThousandShips commented Feb 1, 2024

Also BMFont is open source, do you mean another open source one?

@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:import labels Feb 1, 2024
@dustdfg
Copy link
Contributor Author

dustdfg commented Feb 1, 2024

Also BMFont is open source, do you mean another open source one?

Yeah bad wording... I would say a very bad wording because I meant that BMFont is for windows only (as I know) and to run it on the linux you need something like wine... But this is a web tool which is run in browser

@AThousandShips
Copy link
Member

Would you like me to fix your branch for you?

@dustdfg
Copy link
Contributor Author

dustdfg commented Feb 1, 2024

Would you like me to fix your branch for you?

Are you about redirecting from 4.2 branch into master? I though I did it. If you are about something another my answer is yes because I even don't know what you are about

@AThousandShips
Copy link
Member

AThousandShips commented Feb 1, 2024

I'm about the thing I explained above 🙂 see all the commits that aren't yours, you didn't make those 96 commits, see here

@dustdfg
Copy link
Contributor Author

dustdfg commented Feb 1, 2024

I'm about the thing I explained above 🙂 see all the commits that aren't yours, you didn't make those 96 commits

Ahh... Ok. I opened the link from your comment. I think I can do myself at least to try

@dustdfg dustdfg force-pushed the patch-1 branch 2 times, most recently from cdacea2 to a4912a5 Compare February 1, 2024 18:04
@AThousandShips
Copy link
Member

AThousandShips commented Feb 1, 2024

I'd remove the "open-source" part, unless you also add it to the main part, as BMFont is open-source, it's only BMGlyph that isn't, and I don't think it matters to specify the difference here

Currently it implies that this is the only one of the three which is open source

Add link to *open-source* alternative of BMFont editor
@mhilbrunner mhilbrunner merged commit a9f5cc7 into godotengine:master Feb 6, 2024
@mhilbrunner
Copy link
Member

Thanks!

@mhilbrunner
Copy link
Member

Cherry-picked to 4.2 in #9648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:import

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants