Skip to content

Conversation

@31
Copy link
Contributor

@31 31 commented Feb 4, 2024

Added a reference to the variant compatibility rules and linked to it from the top of the page, to start with. Then, I looked for references to doc_c_sharp_variant that seem like they should probably directly point at the variant compatibility section. And I added a brief description to the section to establish some context when you click a direct reference to that section.

In most cases, Variant isn't actually being used--the compatibility rules just have consequences all over the place.

I was tempted to change the section name from Variant-compatible types to Variant-compatible type to avoid a lot of manual reference naming, but resisted it to avoid unnecessary churn and external link breakage.

@raulsntos raulsntos added topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Feb 4, 2024
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thank you!

@mhilbrunner mhilbrunner merged commit 840b629 into godotengine:master Feb 4, 2024
@mhilbrunner
Copy link
Member

Thanks! Merged.

@31 31 deleted the dev/31/variant-ref branch February 5, 2024 03:44
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2 in #9648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:dotnet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants