Skip to content

Conversation

@31
Copy link
Contributor

@31 31 commented Feb 4, 2024

These orders are different:

``PackedInt32Array`` ``int[]``
``PackedInt64Array`` ``long[]``
``PackedByteArray`` ``byte[]``
``PackedFloat32Array`` ``float[]``
``PackedFloat64Array`` ``double[]``
``PackedStringArray`` ``string[]``
``PackedColorArray`` ``Color[]``
``PackedVector2Array`` ``Vector2[]``
``PackedVector3Array`` ``Vector3[]``

``PackedByteArray`` ``byte[]``
``PackedInt32Array`` ``int[]``
``PackedInt64Array`` ``long[]``
``PackedFloat32Array`` ``float[]``
``PackedFloat64Array`` ``double[]``
``PackedStringArray`` ``string[]``
``PackedVector2Array`` ``Godot.Vector2[]``
``PackedVector3Array`` ``Godot.Vector3[]``
``PackedColorArray`` ``Godot.Color[]``

This can be a problem if you want to visually inspect both lists to see if they're the same. Not super important, but since I spotted it, figured I'd submit a fix.

The Variant page essentially orders by who defined the type (.NET, Godot) then by data size, which seems reasonable enough to me, so picked that one.

@raulsntos raulsntos added topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Feb 4, 2024
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the consistent order is appreciated.

@skyace65 skyace65 merged commit f94b73a into godotengine:master Feb 4, 2024
@skyace65
Copy link
Contributor

skyace65 commented Feb 4, 2024

Thanks!

@31 31 deleted the dev/31/packed-order branch February 4, 2024 17:11
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2 in #9648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:dotnet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants