C#: Remove references to GODOT_SERVER and GODOT_HTML5 defines
#9793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `GODOT_SERVER` preprocessor define is no longer available in Godot 4, since the dedicated server platform was removed. - Replaced a reference to `GODOT_HTML5` with `GODOT_WEB` since that platform was also renamed in Godot 4. - Remove note about `<DefineConstants>` that only really applies to Godot 3.
raulsntos
added
bug
topic:dotnet
area:manual
paulloz
approved these changes
Aug 20, 2024
skyace65
approved these changes
Aug 21, 2024
Contributor
|
Thanks! |
Member
|
Cherry-picked to 4.3 in #10038. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODOT_SERVERpreprocessor define is no longer available in Godot 4, since the dedicated server platform was removed.GODOT_HTML5withGODOT_WEBsince that platform was also renamed in Godot 4.<DefineConstants>that only really applies to Godot 3.